-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/upgrade to app router #27
Feature/upgrade to app router #27
Conversation
Great job! I love the parallax effect. For your next OSS contribution, consider splitting your PRs to make it easier to review :) |
Thank you! Of course, I know how a PR should look, the problem here was that I had to bring the website to the same level as it is now. This included (I wrote in the structure how I wanted to do it):
Thank you for your time for reviewing it. |
今マージに準備できています |
Please check it again Thank you! |
I made the ui changes, ready to be checked again. I tried the dark gray bg also some colors to pop stuff out |
Awesome! We're getting there. @itta611 What do you think? |
@regularentropy |
Sorry for the many mentions!! My docker image had done building you can test out the fixed version here: https://devtest.kou-gen.net Here's my proposal: Let's merge it asap, the more it will be lengthened the more fixes will be needed. Thank you for your help and understanding! PS.: Meaning behind my rush is that the whole project was rewritten and as it became open source people might start submitting PRs but my PR flipped the project on its head. That's why we can't pull this so much longer |
Yesterday every design flaw was fixed, if you don't mind, I would merge this PR. I'm just waiting for a feedback. Thanks! |
Alright, let's see how it'll go. I reviewed it once again, and the new site looks great on both desktop and mobile. Merging it in dev. Will deploy to main till the end of this month. |
Please, don't squash the commits! If anything would need fixing, that is the description. The commit history |
Feature/upgrade to app router
Closes #26