Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade to app router #27

Merged
merged 129 commits into from
May 23, 2024
Merged

Feature/upgrade to app router #27

merged 129 commits into from
May 23, 2024

Conversation

joshika39
Copy link
Member

@joshika39 joshika39 commented May 12, 2024

Closes #26

@joshika39 joshika39 marked this pull request as draft May 12, 2024 09:30
@joshika39 joshika39 marked this pull request as ready for review May 12, 2024 10:21
@itta611 itta611 self-requested a review May 12, 2024 11:46
@itta611
Copy link
Collaborator

itta611 commented May 14, 2024

Great job! I love the parallax effect.
I'll finish reviewing this shortly.

For your next OSS contribution, consider splitting your PRs to make it easier to review :)
Thanks!

@joshika39
Copy link
Member Author

joshika39 commented May 14, 2024

Thank you!

Of course, I know how a PR should look, the problem here was that I had to bring the website to the same level as it is now.

This included (I wrote in the structure how I wanted to do it):

  • pr1
    • upgrade the packages (nextjs, react etc.)
    • addig typescript support
  • pr2
    • adding the i18n routing
  • pr3
    • writing the formatters for i18n
  • pr4
    • creating the landing page
  • pr5
    • creating the download page

Thank you for your time for reviewing it.

@joshika39
Copy link
Member Author

joshika39 commented May 15, 2024

今マージに準備できています
レビュー後にマージします

@itta611
Copy link
Collaborator

itta611 commented May 15, 2024

Also, the layout is a bit messy.
Could you fix the layout and specs (e.g. font-size, width) of both pages the same as now?

Thanks!

@joshika39
Copy link
Member Author

Please check it again

Thank you!

@regularentropy
Copy link
Collaborator

regularentropy commented May 17, 2024

image
Regarding animation: Could you please replace linear motion on "with Floorp" with ease in/out?

@joshika39
Copy link
Member Author

@regularentropy, @itta611

I made the ui changes, ready to be checked again. I tried the dark gray bg also some colors to pop stuff out

@regularentropy
Copy link
Collaborator

Awesome! We're getting there.

  1. Please speed up the ease-in/out
  2. Also, the colour pallet is too contrasted here. image
    image

@itta611 What do you think?

@joshika39
Copy link
Member Author

@regularentropy
What do you mean by contrasted? I am not at home in UI Design

@joshika39
Copy link
Member Author

@regularentropy, @itta611

Sorry for the many mentions!!

My docker image had done building you can test out the fixed version here: https://devtest.kou-gen.net

Here's my proposal: Let's merge it asap, the more it will be lengthened the more fixes will be needed.
After it have been merged, I'll go through it and create the necessary issues from the leftover stuff (if there is such things).

Thank you for your help and understanding!

PS.: Meaning behind my rush is that the whole project was rewritten and as it became open source people might start submitting PRs but my PR flipped the project on its head. That's why we can't pull this so much longer

@joshika39
Copy link
Member Author

@itta611, @regularentropy

Yesterday every design flaw was fixed, if you don't mind, I would merge this PR.

I'm just waiting for a feedback.

Thanks!

@regularentropy
Copy link
Collaborator

Alright, let's see how it'll go.

I reviewed it once again, and the new site looks great on both desktop and mobile.

Merging it in dev. Will deploy to main till the end of this month.

@joshika39
Copy link
Member Author

joshika39 commented May 23, 2024

Please, don't squash the commits!

If anything would need fixing, that is the description. The commit history

@regularentropy regularentropy merged commit f4a5201 into Floorp-Projects:dev May 23, 2024
joshika39 pushed a commit that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ウェブサイトをメンテナンス可能にする計画
3 participants