Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Demo" suffix from Tab title #103

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Remove "Demo" suffix from Tab title #103

merged 2 commits into from
Jul 3, 2024

Conversation

javier-godoy
Copy link
Member

No description provided.

@javier-godoy javier-godoy requested review from mlopezFC and paodb July 3, 2024 13:29
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@javier-godoy
Copy link
Member Author

Quality Gate Failed See analysis details on SonarCloud

Make sure the regex used here, which is vulnerable to polynomial runtime due to backtracking, cannot lead to denial of service.
text = text.replaceFirst("\\s*+[Dd]emo$", "");

Possessive qualifiers do not backtrack... (Moreover, the input is not user-controlled and it is usually a small number of characters.)

@paodb paodb merged commit 58e156a into master Jul 3, 2024
1 of 2 checks passed
@paodb paodb deleted the demo-suffix branch July 3, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants