Skip to content

Commit

Permalink
remove deprecated actions
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyhallett committed Oct 17, 2024
1 parent 8ceb999 commit 42fde60
Showing 1 changed file with 22 additions and 21 deletions.
43 changes: 22 additions & 21 deletions .github/workflows/push_pull.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,20 +67,20 @@ jobs:

# above are common steps for push and pull

# pull only
- name: upload vsix
if: github.event_name == 'pull_request' && !github.event.pull_request.draft
uses: actions/upload-artifact@v2
with:
name: FineCodeCoverage ( zipped vsix)
path: ${{env.VSIX}}
# pull only - todo update to v4
# - name: upload vsix
# if: github.event_name == 'pull_request' && !github.event.pull_request.draft
# uses: actions/upload-artifact@v2
# with:
# name: FineCodeCoverage ( zipped vsix)
# path: ${{env.VSIX}}

- name: upload vsix 2022
if: github.event_name == 'pull_request' && !github.event.pull_request.draft
uses: actions/upload-artifact@v2
with:
name: FineCodeCoverage2022 ( zipped vsix)
path: ${{env.VSIX2022}}
# - name: upload vsix 2022
# if: github.event_name == 'pull_request' && !github.event.pull_request.draft
# uses: actions/upload-artifact@v2
# with:
# name: FineCodeCoverage2022 ( zipped vsix)
# path: ${{env.VSIX2022}}

# push only
- name: create release
Expand Down Expand Up @@ -134,11 +134,12 @@ jobs:
manifestPath: ${{github.workspace}}\vs-market-place-manifest-2022.json
vsixPath: ${{env.VSIX2022}}

- name: comment - released and added to marketplace
if: github.event_name == 'push'
uses: tonyhallett/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
comment: released ${{steps.next-version.outputs.version_tag}} and available on marketplace
addTo: pullandissues
# todo - actions/upload-artifact@v4 now outputs the artifact-url
# - name: comment - released and added to marketplace
# if: github.event_name == 'push'
# uses: tonyhallett/[email protected]
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# with:
# comment: released ${{steps.next-version.outputs.version_tag}} and available on marketplace
# addTo: pullandissues

0 comments on commit 42fde60

Please sign in to comment.