New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(holiday): australia regional holidays #378

Open

curbengh wants to merge 1 commit into FossifyOrg:master from curbengh:au-2025-2

Contributor

curbengh commented Nov 16, 2024

What is it?

Bugfix
Feature
Codebase improvement

Description of the changes in your PR

Re-add regional holidays removed by Holidays update #173, at least until an appropriate automation and UI are in place.
Source

Acknowledgement

I read the contribution guidelines.


          feat(holiday): australia regional holidays

5a1eb81

Contributor

tswistak commented Nov 18, 2024

IMHO, you should rather modify the generator (https://github.com/FossifyOrg/Calendar/tree/master/.github/workflows/holiday-generator) to also consider regional holidays, not add them manually. They will get lost when the generator runs next time.

Another thing, as @naveensingh said in his comment (#173 (comment)):

Let's wait for some user feedback before making any further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet