Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stream data from db, build snapshot incrementally #1516

Merged

Conversation

segfault-magnet
Copy link
Contributor

The snapshot command will now iterate over the chain state and write it in batches to parquet files or JSON, depending on the CLI parameter passed.

The state and balances are still present in ContractConfig. They will be removed when we finish the snapshot reading part.

@segfault-magnet segfault-magnet added the enhancement New feature or request label Nov 24, 2023
@segfault-magnet segfault-magnet self-assigned this Nov 24, 2023
Copy link
Member

@MitchTurner MitchTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Is the intention to merge this into master after the parent branch gets merged?

@segfault-magnet
Copy link
Contributor Author

segfault-magnet commented Dec 1, 2023

Is the intention to merge this into master after the parent branch gets merged?

Merging anything into master is still a ways off. Our current approach is to have everything land into feature/regenesis.

Currently, the PRs look something like this:
feature/regenesis <- PR ( #1459 ) <- PR ( #1474 ) <- PR (#1516) <- PR (#1519)

@segfault-magnet segfault-magnet merged commit b3f2098 into feature/stream-genesis-state Dec 1, 2023
17 of 18 checks passed
@segfault-magnet segfault-magnet deleted the feature/snapshot_generation branch December 1, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants