Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TPS benchmark to work with latest changes #2515

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fixed TPS benchmark to work with latest changes #2515

wants to merge 10 commits into from

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Dec 26, 2024

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx self-assigned this Dec 26, 2024
@xgreenx xgreenx requested a review from a team December 26, 2024 16:44
@xgreenx xgreenx added the no changelog Skip the CI check of the changelog modification label Dec 26, 2024
rymnc
rymnc previously approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was helping harsh with this specific thing yesterday

@xgreenx xgreenx requested a review from rymnc December 31, 2024 00:10
@xgreenx xgreenx enabled auto-merge (squash) December 31, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

@rymnc rymnc Awaiting requested review from rymnc

At least 2 approving reviews are required to merge this pull request.

Assignees

@xgreenx xgreenx

Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xgreenx @AurelienFT @rymnc