[BUGFIX?] Reset CWD before Preloader #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my machine and this does indeed fix this issue! |
8 tasks
|
wow i guess i became a bugfinder now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the game from the command line and the current working directory is not the executable's directory the Preloader will fail to find the files it needs, this PR aims to fix this problem. This could perhaps also fix #2444 although it seems to be kinda unrelated.
I know that ideally you'd use
lime run PLATFORMto run the game without recompiling, but this would not be the case for when downloading the game, specially for Linux players that for whatever reason would like to run it through a terminal without having to change the CWD.From what I tested it doesn't break anything. Here's a before and after of the problem:
(Before was done in Windows cuz I'm too lazy to recompile, but it should be consistent regardless of the platform)
before.mp4
after.mp4