Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fixed Song Synchronization #2706

Closed
wants to merge 7 commits into from
Closed

[BUGFIX] Fixed Song Synchronization #2706

wants to merge 7 commits into from

Conversation

VirtuGuy
Copy link

@VirtuGuy VirtuGuy commented Jun 8, 2024 •
edited
Loading

Probably should've explained this when I first made the pull request, but this person explained it well.

image

@VirtuGuy VirtuGuy changed the base branch from main to develop June 8, 2024 16:17
@VirtuGuy VirtuGuy changed the title Fixed vocal synchronizing [BUGFIX] Fixed vocal synchronizing Jun 8, 2024
charlesisfeline

This comment was marked as off-topic.

Sign in to view

@VirtuGuy VirtuGuy changed the title [BUGFIX] Fixed vocal synchronizing [BUGFIX] Fixed Vocal Resynchronization Jun 8, 2024
@VirtuGuy VirtuGuy changed the title [BUGFIX] Fixed Vocal Resynchronization [BUGFIX] Fixed Song Synchronization Jun 11, 2024
@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. status: needs clarification Requires more info from the contributor. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jun 17, 2024
@EliteMasterEric
Copy link
Member

What does this actually solve and how?

@AbnormalPoof
Copy link
Contributor

AbnormalPoof commented Jun 17, 2024 •
edited
Loading

What does this actually solve and how?

This PR addresses an issue with the instrumental being out-of-sync with the vocals when you first load into a song. (However, restarting the song properly syncs the vocals and instrumental.) I'm unsure if you are able to reproduce the bug on your end.

PlayState's resyncVocals() function is modified to pause the instrumental in addition to the vocals.

Before:

Before.mp4

After:

After.mp4

@AbnormalPoof AbnormalPoof mentioned this pull request Jun 23, 2024
Closed
cyn0x8
cyn0x8 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@cyn0x8 cyn0x8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desperately needed; its a bit annoying to have to pause/unpause nearly every single time i open a song to fix the desync, especially when testing charting

@EliteMasterEric EliteMasterEric added the small A small pull request with 10 or fewer changes label Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@NotHyper-474 NotHyper-474 mentioned this pull request Jul 24, 2024
Merged
@EliteMasterEric
Copy link
Member

Probably going to close this in favor of #3058.

@EliteMasterEric EliteMasterEric added status: duplicate Issue or PR is redundant to another. and removed status: needs clarification Requires more info from the contributor. labels Jul 25, 2024
@NotHyper-474 NotHyper-474 mentioned this pull request Sep 13, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@cyn0x8 cyn0x8 cyn0x8 approved these changes

Assignees
No one assigned
Labels
small A small pull request with 10 or fewer changes status: duplicate Issue or PR is redundant to another. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VirtuGuy @EliteMasterEric @AbnormalPoof @cyn0x8 @charlesisfeline