Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Issue and PR templates tweaks #3003

Merged
merged 10 commits into from
Jul 11, 2024

Conversation

Hundrec
Copy link
Contributor

@Hundrec Hundrec commented Jul 11, 2024

Thanks @tposejank for the awesome templates!

I went through and tweaked a few things in each template to further improve clarity for users.

Some changes include:

  • Adding Itch.io (Web) to the Platform list
  • Directing users to the logs folder for crash reports
  • Removing the unused data portion of the PR template
  • Adding a screenshots/videos section to the PR template
  • Rewording a few sentences for extra clarity

@EliteMasterEric
Copy link
Member

LGTM

@EliteMasterEric EliteMasterEric merged commit 9b483de into FunkinCrew:main Jul 11, 2024
Copy link
Contributor

@tposejank tposejank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro took over the entire front history 😭

I forgot to approve cause I was playing fortnite, pretty cool

I'd just say "Downloadable build" feels unnecessary

Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@Hundrec
Copy link
Contributor Author

Hundrec commented Jul 11, 2024

Bro took over the entire front history 😭

I forgot to approve cause I was playing fortnite, pretty cool

I'd just say "Downloadable build" feels unnecessary

Hope you won :P

I felt like that label was the easiest way to differentiate between the web and desktop versions. People seem to get pretty confused about their OS/browser otherwise!

@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants