Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Legacy Revert #3114

Closed

Conversation

sphis-Sinco
Copy link

Does this PR close any issues? If so, link them below.

Nope

Briefly describe the issue(s) fixed.

QOL: reverts input to lgact for if its not detected. don't ask why I picked legacy

Include any relevant screenshots or videos.

beep

@sphis-Sinco sphis-Sinco changed the title Legacy Revert [ENHANCEMENT] Legacy Revert Aug 19, 2024
@sphis-Sinco sphis-Sinco changed the base branch from main to develop August 19, 2024 21:00
@Cartridge-Man
Copy link
Contributor

I mean, I see the idea of what it does, like using legacy as a fallback but at that point I would just make the game just send an error message and then give a window notification saying it didn’t load the thing properly

HOWEVER, I would probably just change this to add an if statement asking if the currently not working input system is NOT the weekend 1 input, then it will switch to that

@EliteMasterEric
Copy link
Member

If you're switching the scoring function, it should spit an error in the console and return a value of 0 so you can immediately investigate the issue (i.e. the current behavior). If you set the scoring function, and it seems to work when you're in-game, it may take a while to notice the problem.

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: rejected Issue did not pass review or PR cannot be approved. labels Aug 19, 2024
@sphis-Sinco sphis-Sinco deleted the legacy-scoring-revert branch October 1, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants