Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/acdd compliance #290

Merged
merged 14 commits into from
Aug 20, 2024
Merged

Features/acdd compliance #290

merged 14 commits into from
Aug 20, 2024

Conversation

ladsmund
Copy link
Contributor

No description provided.

@ladsmund ladsmund force-pushed the features/acdd_compliance branch 3 times, most recently from 083bffe to b78dad6 Compare August 17, 2024 05:27
Copy link
Member

@BaptisteVandecrux BaptisteVandecrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/pypromice/process/aws.py Show resolved Hide resolved
src/pypromice/process/aws.py Show resolved Hide resolved
src/pypromice/utilities/git.py Outdated Show resolved Hide resolved
tests/data/test_config1_raw.toml Outdated Show resolved Hide resolved
tests/e2e/test_get_l2.py Outdated Show resolved Hide resolved
@ladsmund ladsmund force-pushed the features/acdd_compliance branch 3 times, most recently from 3ff63ee to 22739d6 Compare August 19, 2024 12:16
get_l2 were previously also loading vars and meta in addition to AWS.
AWS is populating meta with source information during instantiation.
…tadata files

* Refactor getVar getMeta
* Use pypromice.resources instaed of pkg_resources
The format string was previously selected from the last l0 file.
* Added test case for output meta data
* Added json formatted source string to attributes
* Added title string to attributes
* Updated ID string to include level
* Added utility function for fetching git commit id
* Added test station configuration
* Cleanup test data files
* Added data issues path to process_test.yml
Validate attribute keys in e2e test
@ladsmund ladsmund force-pushed the features/acdd_compliance branch from 22739d6 to 0ccf858 Compare August 19, 2024 13:32
Copy link
Member

@PennyHow PennyHow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things, mainly just questions about things I didn't quite understand. All looks good otherwise.

.github/workflows/process_test.yml Outdated Show resolved Hide resolved
src/pypromice/process/L1toL2.py Show resolved Hide resolved
tests/unit/bufr_export/DY2.bufr Show resolved Hide resolved
@ladsmund ladsmund merged commit 3357e62 into develop Aug 20, 2024
3 checks passed
@ladsmund ladsmund deleted the features/acdd_compliance branch August 20, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants