-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/acdd compliance #290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladsmund
force-pushed
the
features/acdd_compliance
branch
3 times, most recently
from
August 17, 2024 05:27
083bffe
to
b78dad6
Compare
BaptisteVandecrux
previously approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
ladsmund
force-pushed
the
features/acdd_compliance
branch
3 times, most recently
from
August 19, 2024 12:16
3ff63ee
to
22739d6
Compare
get_l2 were previously also loading vars and meta in addition to AWS. AWS is populating meta with source information during instantiation.
…tadata files * Refactor getVar getMeta * Use pypromice.resources instaed of pkg_resources
The format string was previously selected from the last l0 file.
* Added test case for output meta data * Added json formatted source string to attributes * Added title string to attributes * Updated ID string to include level * Added utility function for fetching git commit id
* Added test station configuration * Cleanup test data files
* Added data issues path to process_test.yml
Validate attribute keys in e2e test
ladsmund
force-pushed
the
features/acdd_compliance
branch
from
August 19, 2024 13:32
22739d6
to
0ccf858
Compare
PennyHow
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor things, mainly just questions about things I didn't quite understand. All looks good otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.