-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-2843: Fix the broken browser channel example #586
base: master
Are you sure you want to change the base?
Conversation
…o support the browser channel example.
CI job passed: https://ci.gpii.net/job/universal-tests/685/ |
documentation/BrowserChannel.md
Outdated
@@ -82,7 +82,7 @@ The workflow between the client and server can be summarised as follows: | |||
The client has been checked in to [../examples/browserChannelClient](../examples/browserChannelClient). To try it out, first | |||
start the GPII in the CloudBased browserChannel test configuration from the root of universal with | |||
|
|||
node gpii.js gpii/configs gpii.config.cloudBased.production | |||
node gpii.js gpii/configs gpii.config.development.all.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it will be more helpful to direct the user to one of our mock configurations like https://github.com/GPII/universal/blob/master/gpii/configs/mocks/gpii.config.development.all.local.mock.windows.json5 which will allow them to see the results of a wider range of preference sets
…ort the browser channel example.
I've made the change. Ready for another look, @amb26. |
CI job passed: https://ci.gpii.net/job/universal-tests/686/ |
@amb26, now the initial user settings are set and returned at
This pull request is ready to be reviewed. |
CI job failed: https://ci.gpii.net/job/universal-tests/727/ |
ok to test |
CI job failed: https://ci.gpii.net/job/universal-tests/728/ |
…ocker container to find out if it helps to work around the couchdb connection failure.
CI job passed: https://ci.gpii.net/job/universal-tests/729/ |
CI job passed: https://ci.gpii.net/job/universal-tests/732/ |
ok to test |
CI job failed: https://ci.gpii.net/job/universal-tests/884/ |
CI job passed: https://ci.gpii.net/job/universal-tests/886/ |
Use the GPII config that includes the local flow manager to support the browser channel example.