Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2946: "momentary", "maintained", and "hybrid" key token gestures. #605

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

stegru
Copy link
Member

@stegru stegru commented Apr 17, 2018

This provides the ability to auto-detect whether or not the user wants to use a token device in a "tap:on / tap:off" or "present:on / remove:off" manner.

  • If the token is removed quickly, then it remain keyed in until a token is presented again.
  • If the token is removed after a while, then it will key out.

This works for both the external NFC reader, and USB key. The VAIO's proximity device remains the same as before.

@stegru
Copy link
Member Author

stegru commented Apr 17, 2018

// Listeners can have either "momentary", "maintained", or "hybrid" gesture modes:
// - Momentary: token is presented to key-in, then presented again to key-out, like a caps-lock key. (momentary = true)
// - Maintained: token is presented to key-in, then removed to key-out, like the shift key. (momentary = false)
// - Hybrid mode detects what the user is trying to do, based on how soon the token is removed. (detectMode = true)

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/820/

@gpii-bot
Copy link

gpii-bot commented May 9, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/840/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/842/

@gtirloni
Copy link
Contributor

gtirloni commented Jun 1, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Jun 1, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/881/

@javihernandez
Copy link
Member

@stegru can you update this with current master and get passed through CI?

@gpii-bot
Copy link

gpii-bot commented Jul 9, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/938/

@gpii-bot
Copy link

gpii-bot commented Jul 9, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/939/

@gpii-bot
Copy link

gpii-bot commented Jul 9, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/940/

@stegru
Copy link
Member Author

stegru commented Jul 9, 2018

Looks like it's ok now, @JavierJF

@stegru
Copy link
Member Author

stegru commented Jul 9, 2018

oops, I meant @javihernandez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants