Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3851: Updated highContrast solution to use our custom themes #773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javihernandez
Copy link
Member

@javihernandez javihernandez commented Apr 10, 2019

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/1702/

@amb26
Copy link
Member

amb26 commented May 9, 2019

@javihernandez considers we might skip this one -

[13:00] <jhernandez> this was yet another "fallback" thing to "ensure" that the right high contrast theme was applied
[13:01] <jhernandez> before finding the real solution for one of the problems we had with high contrast on 1809
[13:02] <jhernandez> that is, getting the localised highcontrast theme name
[13:02] <jhernandez> when I say 1809 I mean Windows 1809 (not a JIRA or the like)
[13:03] <Bosmon> jhernandez - right
[13:04] <Bosmon> But this pull just looks like it normalises the names of some desktop themes.... I'm a bit puzzled though
[13:04] <Bosmon> Are we just storing "our own" themes in the same directory along with the builtin ones?
[13:04] <jhernandez> yes
[13:04] <Bosmon> So "hc1" is a builtin scheme?
[13:05] <jhernandez> but as stegru indicated, our themes are "uglier" than the ones from MS
[13:05] <jhernandez> yes
[13:07] <jhernandez> that's why in one hand, I thought it was a good idea to use our own custom themes - in the other hand, wasn't sure it was such good idea, why shipping our custom themes if they're supposed to be there?
[13:08] <jhernandez> don't have a strong opinion, so will be happy with either decision we take

@javihernandez
Copy link
Member Author

@stegru, what are your thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants