Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/86] 테스트 수정 사항 반영 PR #87

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[Feat/86] 테스트 수정 사항 반영 PR #87

merged 3 commits into from
Sep 23, 2024

Conversation

rimi3226
Copy link
Contributor

🚀 개요

테스트 수정 사항 반영 PR

🔍 변경사항

  • 매칭 found 이후 사용자가 disconnect 돼서 success 응답을 못받을 경우 로딩되는 시간 단축
  • 매칭 성공했을 때 quit 버튼 추가
  • retry priority 50 -> 45

⏳ 작업 내용

  • retry priority 낮춰서 테스트해보기
  • 매칭 성공했을 때 quit 버튼 추가해서 테스트해보기
  • 매칭 found 이후 matching-success emit 안 올 경우 5초동안 기다리지 않고 2,3초만 기다리기 ( 둘 다 해보고 더 좋은 걸로 설정) - sender일 때 5초→3초, receiver일 때 3초→2초

📝 논의사항

5초, 3초 기다리는걸 3초, 2초로 변경하니까 훨씬 좋습니다! 이렇게 가면 될 것 같아요!!
나머지 테스트도 통과됐습니다

  • 매칭 성공했을 때 quit 버튼 추가해서 테스트한 이미지입니다.
    image
    image

@rimi3226 rimi3226 requested a review from Eunjin3395 September 23, 2024 09:01
@rimi3226 rimi3226 self-assigned this Sep 23, 2024
@rimi3226 rimi3226 linked an issue Sep 23, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@Eunjin3395 Eunjin3395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 고생하셨습니다!!!👍

@rimi3226 rimi3226 merged commit 8d30880 into develop Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feat] 테스트 수정사항 반영
2 participants