feat: minor adapter improvements

Gearbox-protocol · Jul 24, 2024 · 46b303f · 46b303f
1 parent da91339
commit 46b303f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 11 deletions.
diff --git a/contracts/adapters/convex/ConvexV1_BaseRewardPool.sol b/contracts/adapters/convex/ConvexV1_BaseRewardPool.sol
@@ -249,7 +249,7 @@ contract ConvexV1BaseRewardPoolAdapter is AbstractAdapter, IConvexV1BaseRewardPo
         external
         override
         creditFacadeOnly // U:[CVX1R-3]
-        returns (bool enableSafePrices)
+        returns (bool)
     {
         address creditAccount = _creditAccount(); // U:[CVX1R-10]
 

diff --git a/contracts/adapters/convex/ConvexV1_Booster.sol b/contracts/adapters/convex/ConvexV1_Booster.sol
@@ -150,18 +150,23 @@ contract ConvexV1BoosterAdapter is AbstractAdapter, IConvexV1BoosterAdapter {
         return _supportedPids.values();
     }
 
+    struct Pool {
+        uint256 pid;
+        address curveToken;
+        address convexToken;
+        address phantomToken;
+    }
+
     /// @notice Serialized adapter parameters
     function serialize() external view returns (bytes memory serializedData) {
         uint256[] memory supportedPids = getSupportedPids();
-        address[] memory supportedPhantomTokens = new address[](supportedPids.length);
-
         uint256 len = supportedPids.length;
-
+        Pool[] memory supportedPools = new Pool[](len);
         for (uint256 i = 0; i < len; ++i) {
-            supportedPhantomTokens[i] = pidToPhantomToken[supportedPids[i]];
+            uint256 pid = supportedPids[i];
+            supportedPools[i] = Pool(pid, pidToCurveToken[pid], pidToConvexToken[pid], pidToPhantomToken[pid]);
         }
-
-        serializedData = abi.encode(creditManager, targetContract, supportedPids, supportedPhantomTokens);
+        serializedData = abi.encode(creditManager, targetContract, supportedPools);
     }
 
     // ------------- //

diff --git a/contracts/adapters/lido/LidoV1.sol b/contracts/adapters/lido/LidoV1.sol
@@ -70,7 +70,9 @@ contract LidoV1Adapter is AbstractAdapter, ILidoV1Adapter {
 
         uint256 balance = IERC20(weth).balanceOf(creditAccount); // U:[LDO1-4]
         if (balance > leftoverAmount) {
-            _submit(balance - leftoverAmount);
+            unchecked {
+                _submit(balance - leftoverAmount);
+            }
         }
         return false;
     }

diff --git a/contracts/adapters/zircuit/ZircuitPoolAdapter.sol b/contracts/adapters/zircuit/ZircuitPoolAdapter.sol
@@ -162,9 +162,6 @@ contract ZircuitPoolAdapter is AbstractAdapter, IZircuitPoolAdapter {
             address token = cm.getTokenByMask(1 << i);
             try IPhantomToken(token).getPhantomTokenInfo() returns (address target, address depositedToken) {
                 if (target == targetContract) {
-                    _getMaskOrRevert(token);
-                    _getMaskOrRevert(depositedToken);
-
                     tokenToPhantomToken[depositedToken] = token;
                     if (_supportedUnderlyings.add(depositedToken)) emit AddSupportedUnderlying(depositedToken, token);
                 }