Merge pull request #140 from Gearbox-protocol/v3-pendle-mellow

fix: prohibit mellow deposits with disallowed underlyings, even with …
Gearbox-protocol · Sep 2, 2024 · d938b18 · d938b18
2 parents 3e96f58 + 247e7b6
commit d938b18
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/contracts/adapters/mellow/MellowVaultAdapter.sol b/contracts/adapters/mellow/MellowVaultAdapter.sol
@@ -50,7 +50,7 @@ contract MellowVaultAdapter is AbstractAdapter, IMellowVaultAdapter {
         if (amounts.length != len) revert IncorrectArrayLengthException(); // U:[MEL-3]
 
         for (uint256 i = 0; i < len;) {
-            if (amounts[i] > 0 && !isUnderlyingAllowed[underlyings[i]]) {
+            if (!isUnderlyingAllowed[underlyings[i]]) {
                 revert UnderlyingNotAllowedException(underlyings[i]); // U:[MEL-3]
             }
 

diff --git a/contracts/test/unit/adapters/mellow/MellowVaultAdapter.unit.t.sol b/contracts/test/unit/adapters/mellow/MellowVaultAdapter.unit.t.sol
@@ -78,7 +78,7 @@ contract MellowVaultAdapterUnitTest is
         vm.prank(creditFacade);
         adapter.deposit(address(0), incorrectAmounts, 0, 789);
 
-        amounts[1] = 0;
+        _setUnderlyingsStatus(3);
 
         address[] memory tokensToApprove = new address[](1);
         tokensToApprove[0] = tokens[0];