test: fix and improve ci #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveej
reviewed
Nov 1, 2023
flake.nix
Outdated
| @@ -5,7 +5,7 @@ | |||
| versions.url = "github:holochain/holochain?dir=versions/0_2"; | |||
| holonix.url = "github:holochain/holochain"; | |||
| holonix.inputs.versions.follows = "versions"; | |||
| holonix.inputs.holochain.url = "github:holochain/holochain/holochain-0.2.2"; | |||
| holonix.inputs.holochain.url = "github:holochain/holochain/holochain-0.2.3-beta-rc.1"; | |||
There was a problem hiding this comment.
we don't build this holochain tag on CI. see here what's used for the 0_2 versions flake
There was a problem hiding this comment.
Right, thanks for clarifying @steveej
There was a problem hiding this comment.
The simple solution with that one is that we should get 0.2.3 released. Just waiting on holochain/holochain#2951 and we can go ahead with that
mattyg
reviewed
Nov 7, 2023
.github/workflows/test.yml
Outdated
| @@ -64,5 +64,8 @@ jobs: | |||
| target | |||
| key: ${{ runner.os }}-build-${{ hashFiles('Cargo.lock') }} | |||
|
|
|||
| # - name: tmate session | |||
| # uses: mxschmitt/action-tmate@v3 | |||
mattyg
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.