WIP Explore Latex in subplot tags #7958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See forum post for background. Not straightforward since we run a special PSL function to set those. Tried the obvious (relying on the other places we handle this) but get a crashing PostSCript. Will follow up.
joa-quim
reviewed
Oct 20, 2023
src/gmt_plot.c
Outdated
| @@ -2675,24 +2675,24 @@ GMT_LOCAL void gmtplot_consider_internal_annotations (struct GMT_CTRL *GMT, stru | |||
| PSL_settextmode (PSL, PSL_TXTMODE_HYPHEN); /* Back to leave as is */ | |||
| } | |||
|
|
|||
| GMT_LOCAL void gmtplot_map_label (struct GMT_CTRL *GMT, double x, double y, char *label, double angle, int just, unsigned int axis, bool below) { | |||
| GMT_LOCAL void gmtplot_map_label (struct GMT_CTRL *GMT, double x, double y, char *label, double angle, int just, unsigned int axis, bool below, unsigned int feature) { | |||
There was a problem hiding this comment.
unsigned int feature. Aren't enums signed ints? So this one should be signed int too, no? Besides unsigned ints are a pain.
There was a problem hiding this comment.
feature is now a enum GMT_enum_feature
|
For testing, here is a small subplot that fails due to Latex code: I will update the subplot documentation with a note that Latex expressions in the -A is currently not allowed. |
PaulWessel
added a commit
that referenced
this pull request
Nov 5, 2023
See #7958 for background. This updates the documentation until we have a better solution.
|
See #8016 for documentation warning. |
PaulWessel
added a commit
that referenced
this pull request
Nov 5, 2023
* Warn that Latex cannot be used in panel tags See #7958 for background. This updates the documentation until we have a better solution. * Update doc/rst/source/subplot.rst Co-authored-by: Dongdong Tian <[email protected]> --------- Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this forum post for background. Not straightforward since we run a special PSL function to set those. Tried the obvious (relying on the other places we handle this) but get a crashing PostScript. Will follow up.