Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iron-swipeable-pages 2.0 #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ZepAviator
Copy link

Thanks for the component! I'm working on a 2.0 project and thought I'd convert this over.
No logic changed, just formatting for 2.0, converting to and the listener changes.

Thanks for the component!  I'm working on a 2.0 project and thought I'd convert this over.
No logic changed, just formatting for 2.0, converting <container> to <slot> and the listener changes.
Broke it simplifying if statement.. whoops
@MeTaNoV
Copy link
Collaborator

MeTaNoV commented Mar 12, 2017

Hi @ZepAviator,
the migration has already been started in #54 .
Feel free to play with your own fork, but I'll probably do my own migration once 2.0 will be officially released. I will contain some other changes probably.
You also mixed with a fixes of canCycle but I am not sure it needs to be fixed...
Also, do not hesitate to star the component if you find it useful!
Cheers,
Pascal

@MeTaNoV MeTaNoV closed this Mar 12, 2017
@MeTaNoV MeTaNoV reopened this Mar 30, 2017
@MeTaNoV
Copy link
Collaborator

MeTaNoV commented Mar 30, 2017

@ZepAviator , I created a 2.0-preview branch where you can find a hybrid mode version of the component. Before migrating it to full 2.0, I need to check if mixing hybrid and full work well together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants