Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify change publish options #879

Merged
merged 2 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
757 changes: 371 additions & 386 deletions protobuf/video/sfu/event/events.pb.go

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions protobuf/video/sfu/event/events.proto
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,14 @@ message SfuEvent {
ParticipantUpdated participant_updated = 24;
// ParticipantMigrationComplete is sent when the participant migration is complete
ParticipantMigrationComplete participant_migration_complete = 25;
// ChangePublishOptionsComplete is sent to signal the completion of a ChangePublishOptions request.
ChangePublishOptionsComplete change_publish_options_complete = 26;
// ChangePublishOptions is sent to signal the change in publish options such as a new codec or simulcast layers
ChangePublishOptions change_publish_options = 27;
}
}

message ChangePublishOptions {
models.PublishOption publish_option = 1;
repeated models.PublishOption publish_option = 1;
string reason = 2;
}

message ChangePublishOptionsComplete {
Expand Down
181 changes: 76 additions & 105 deletions protobuf/video/sfu/event/events_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 23 additions & 2 deletions protobuf/video/sfu/models/models.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions protobuf/video/sfu/models/models.proto
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,20 @@ message PublishOption {
// - Half resolution (2 layers) = 640x360
// - Quarter resolution (3 layers) = 320x180
VideoDimension video_dimension = 7;

// The unique identifier for the publish request.
// - This `id` is assigned exclusively by the SFU. Any `id` set by the client
// in the `PublishOption` will be ignored and overwritten by the SFU.
// - The primary purpose of this `id` is to uniquely identify each publish
// request, even in scenarios where multiple publish requests for the same
// `track_type` and `codec` are active simultaneously.
// For example:
// - A user may publish two tracks of the same type (e.g., video) and codec
// (e.g., VP9) concurrently.
// - This uniqueness ensures that individual requests can be managed
// independently. For instance, an `id` is critical when stopping a specific
// publish request without affecting others.
int32 id = 8;
}

message Codec {
Expand Down
27 changes: 27 additions & 0 deletions protobuf/video/sfu/models/models_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading