Fix unnecessarily updating transceivers

GetStream · Dec 18, 2024 · b3c4345 · b3c4345
1 parent 2217b21
commit b3c4345
Show file tree

Hide file tree

Showing 3 changed files with 190 additions and 180 deletions.
diff --git a/...eo/WebRTC/v2/PeerConnection/MediaAdapters/LocalMediaAdapters/LocalAudioMediaAdapter.swift b/...eo/WebRTC/v2/PeerConnection/MediaAdapters/LocalMediaAdapters/LocalAudioMediaAdapter.swift
@@ -275,19 +275,19 @@ final class LocalAudioMediaAdapter: LocalMediaAdapting {
         for options: PublishOptions.AudioPublishOptions,
         with track: RTCAudioTrack
     ) {
-        if let transceiver = transceiverStorage.get(for: options) {
-            transceiver.sender.track = track
-        } else {
-            let transceiver = peerConnection.addTransceiver(
-                trackType: .audio,
-                with: track,
-                init: .init(
-                    direction: .sendOnly,
-                    streamIds: streamIds,
-                    audioOptions: options
-                )
-            )
-            transceiverStorage.set(transceiver, for: options)
+        guard !transceiverStorage.contains(key: options) else {
+            return
         }
+
+        let transceiver = peerConnection.addTransceiver(
+            trackType: .audio,
+            with: track,
+            init: .init(
+                direction: .sendOnly,
+                streamIds: streamIds,
+                audioOptions: options
+            )
+        )
+        transceiverStorage.set(transceiver, for: options)
     }
 }
diff --git a/...RTC/v2/PeerConnection/MediaAdapters/LocalMediaAdapters/LocalScreenShareMediaAdapter.swift b/...RTC/v2/PeerConnection/MediaAdapters/LocalMediaAdapters/LocalScreenShareMediaAdapter.swift
@@ -326,21 +326,21 @@ final class LocalScreenShareMediaAdapter: LocalMediaAdapting, @unchecked Sendabl
         with track: RTCVideoTrack,
         screenSharingType: ScreensharingType
     ) {
-        if let transceiver = transceiverStorage.get(for: options) {
-            transceiver.sender.track = track
-        } else {
-            let transceiver = peerConnection.addTransceiver(
+        guard !transceiverStorage.contains(key: options) else {
+            return
+        }
+
+        let transceiver = peerConnection.addTransceiver(
+            trackType: .screenshare,
+            with: track,
+            init: .init(
                 trackType: .screenshare,
-                with: track,
-                init: .init(
-                    trackType: .screenshare,
-                    direction: .sendOnly,
-                    streamIds: ["\(sessionID)-screenshare-\(screenSharingType)"],
-                    videoOptions: options
-                )
+                direction: .sendOnly,
+                streamIds: ["\(sessionID)-screenshare-\(screenSharingType)"],
+                videoOptions: options
             )
-            transceiverStorage.set(transceiver, for: options)
-        }
+        )
+        transceiverStorage.set(transceiver, for: options)
     }
 
     /// Configures the active screen sharing session with the given type and track.