-
Notifications
You must be signed in to change notification settings - Fork 42
RTM support? #123
Comments
up |
same - any news on a beta 2? |
Sorry for the delay in response. We will hopefully have a build of Glimpse out that works on RC2 in the next few weeks. I'll keep this post updated as work progresses. Thanks for your patience! |
RTM ships on June 27, so you might as well skip an rc2 version at this point unless it also will support RTM |
Thats the plan. |
The problem is, lots of things changed between RC1 and RC2 projects - project.json schema changes, .xproj file changes, global.json file changes, not to mention package and code changes. Microsoft have said that they will provide an automatic upgrade experience from RC2 based solutions to RTM. Not from RC1. So I think this will still leave a lot of manual effort to upgrade. I personally have decided to update to RC2, so when RTM tooling ships I can take advantage of the automatic upgrade. |
The current plan is to update the code to RC2 first, tag it and then start the work for RTM. Depending on the time it takes and if it makes sense, we will release the RC2 version before the RTM. |
Awesome. Feel free to try my RC1 to RC2 upgrade tool out if you like. https://github.com/dazinator/AspNetRC1toRC2UpgradeTool |
Work on this officially starts on Monday. Hopefully wont take more than a week or two. Hard date for completion is the end of the month - there are other things happening which means the work can't go past that. So coming soon :D |
If you haven't noticed work is starting to be checked in here https://github.com/Glimpse/Glimpse.Prototype/tree/avanderhoorn-rtm-update |
Well its here. I've got a version of everything updated to be compatible with RTM. If people could try it out and give me feedback on whether everything works as expected, I can get things updated on nuget. Here is the current feed - https://www.myget.org/gallery/glimpseprototype. |
Thats really weird... I just cloned down music store myself and it ran just fine. My project.json look like:
And my startup.cs looks like:
Are you able to confirm that your setup is similar? |
I have the following as dependency but VS shows me that 2.0.0-beta2-201607261439 is the installed Reference so it should be fine.
I can confirm that Startup.cs looks like that. I now checked a bit what happens. It seems like the result from context is wrongly formatted for me. "$.getJson" is not returning and that makes the HUD completly not render. I then checked the result of: I have no idea why but it seems to return invalid JSON as payload: ...
{
"id": "0233a1ec5c7c3f22a1e52540157799a2",
"ordinal": 524,
"types": ["after-action-invoked"],
"payload": {
"actionId": "2d93d149-adba-4fca-a038-4162a6b96558",
"actionName": "Index",
"actionControllerName": "Home",
"actionInvokedEndTime": "2016-07-27T14:47:11.8773171Z",
"actionInvokedDuration": 27,
64,
"actionInvokedOffset": 0,
76
},
"context": {
"id": "dcc911aba2e540788469117426011cb1",
"type": "Request"
}
}
... I will try later today from another computer and see if it works there. |
Ya thats really weird... let me know how you get on. |
So after some debugging I think I figured out what the reason for the missing HUD is! writer.WriteRawValue(result.ToString(CultureInfo.InvariantCulture)); Magicly the HUD appears! There is however still an issue on both of my computers when running with dotnet core AND using the nuget package:
To reproduce this I moved a freshly cloned "MusicStore" to another location outside of the Glimpse src directory (otherwise it will pick up the local files) and added a NuGet.config: <?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<add key="Glimpse" value="https://www.myget.org/F/glimpseprototype/api/v3/index.json"/>
<add key="NuGet" value="https://api.nuget.org/v3/index.json" />
</packageSources>
</configuration> Then after restore and run it will (at least for me) end up with the error above. |
This could be the problem as I never got the previous version working on MVC5, Dutch over here. But I do have as much as possible set to English. I will check the new version out soon. |
@KoalaBear84 I also have that most things to english but somehow this is set differently. |
Thanks, it looks like the format was still in Dutch. Will work much better in English indeed. |
WOW!!! Great pickup guys and thanks so much for tracking that down. I would never have guessed that. I'll make the fix and get an update onto the feed hopefully in the next 24hrs or so. Will let everyone know when it goes up. My thinking is that this shouldn't effect people using english based systems. |
FYI, it looks like you still need to update the main .nuspec file with netstandard entries. It fails to install on a .Net Core application unless you add an import for dnxcore50. The individual packages install fine, it is just the main Glimpse package that doesn't seem to install correctly. |
@CaptainCow95 good catch, I'll update it as part of the next drop. |
Since miniprofiler has no build for .net core, I would love to see glimpse supporting the rtm build |
Any updates? |
Whats the word chaps, want to plug this in to Orchard 2 and would love an updated nuget package targeting 1.1.0-* if possible. |
ok... just committed an update to get everything working with the final RTW bits (1.0.). This should also work for 1.1. but I haven't done any explicit testing on that yet. Within the next day or two, I hope to get a updated package published so that we can test those bits before pushing a wider update. |
@avanderhoorn I was also updating https://github.com/Jetski5822/Glimpse.Prototype/tree/updatedotnetcore
I was using the xproj stuff so that I can use the global.json project stuff for Orchard2. The branch is also all updated to 1.1.0 too. Would it be worth me doing PR for this stuff? |
@Jetski5822 ya take a look at the latest commits I've done and see what the delta is to what you have. I had a little bit of trouble getting the test projects converted over so maybe thats something that you can take a look at. Regardless, let me know what you find and we can go from there. Currently trying to get a build to the feed, but stuck on this one if anyone has any thoughts - https://github.com/dotnet/cli/issues/5151. |
@avanderhoorn i'm not sure but maybe you can take a peek at https://github.com/JimBobSquarePants/ImageSharp hmm they have seemed to create a special project that manages the version numbers (and they still use xproj) |
Ya ok... Nuget looks like they will have a fix for this issue directly. |
Good news. I just got things working and I have the building and packing end to end. I managed to get a build that had a patch for the problem I was having and we will be able to get a build out. I'm hoping to have bits up on myget tomorrow! |
Wicked news!! Sorry haven't looked at it yet, blocked my some other task :(
…Sent from my iPhone
On 20 Jan 2017, at 07:29, Anthony van der Hoorn ***@***.***> wrote:
Good news. I just got things working and I have the building and packing end to end. I managed to get a build that had a patch for the problem I was having and we will be able to get a build out. I'm hoping to have bits up on myget tomorrow!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
As a note, I got blocked from putting out the release due to some bug in nuget. Currently working through it. |
Ok so I've worked around that issue, hit another roadblock in uploading the packages. Hopefully will get this straightened out soon. |
GREAT NEWS!!! The feed has finally been updated. If you head over to - https://www.myget.org/gallery/glimpseprototype - you will find that 2.0.0-beta2-201701201541 has been deployed. This release includes all the necessary updates to target RTM v1.x. Note, this update is purely targeted at the infrastructure side of things. Before making further changes I want to make sure we have all our ducks lined up there and that everything continues to work as expected. Once we get that validation I'll be able to move onto the next stage... providing a major update to the client and the data we collect. But before we do that, I need to get the ok on this. So please take the opportunity to try things out and let me know if you have any thoughts. Additionally thanks for your patients! // @joeaudette, @Noeek, @dazinator, @WolfspiritM, @KoalaBear84, @KLuuKer, @alaatm, @karldodd, @kyurthich, @Jetski5822 |
@avanderhoorn i added the brand spanking new beta bits, added the 2 UseGlimpse()'s and.... praise |
Thanks. I stopped checking out ASP.NET Core because Glimpse did not work. Now I could start explore it again. I hope it would be sooner because you started working at Microsoft :P I did the following, as not everyone (myself included) knows how to work with MyGet etc.:
Now Glimpse 2.x beta will be included in the project. To use it follow the normal steps:
** EDIT, This exception is not shown if you put it BEFORE :) ** @avanderhoorn The dashboard works, but the Glimpse 'site' (glimpse/client/index.html) does not. Is this a known error? Here is the exception:
|
@KoalaBear84 Thanks for the writeup that people will be able to use! Re timing, you will find all sorts of interesting things when you join a big company ;) Re this issue... I'm seeing a lot of browser link in there, is there any chance you can comment out browser link and see if that fixe the issue? |
Great. I didn't disable it. But you have to put it BEFORE "app.UseBrowserLink();" (and also placed it before "app.UseDeveloperExceptionPage();", so Glimpse will process it before it falls in the hands from BrowserLink :D. Thanks! It solved the issue (Y) |
Any updates? |
Hi. I'm trying to use Glimpse with an ASP.NET Core 2.0 app and I'm getting the following error:
Any thoughts on how I could fix this? It looks like Glimpse should reference Microsoft.Extensions.DependencyInjection 2.0.0 or higher. |
Is the project still active or any updates? because the nuget was not updated with beta2 |
In the beginning of ASP.NET Core I waited and waited, because I wanted Glimpse to be part of the journey of learning / adapting to ASP.NET Core. Also thought that when it was 'acquired' by Microsoft it would get better. But it is a little left behind I guess which is a pity. As it is a really beautiful tool. |
Feels like glimpse for .Net is unmaintained, as the developers are working on glimpse for node.js.
After watching the code, I guess there is some work to get glimpse working with .net core 2.0. As there is a lot refactoring with Razor and also DiagnosticAdapter has changed. |
If it helps I am working on this in my spare time... it's just that between everything that's happening I haven't been able to give it as much time as I want. I finished the conversion over to .Net 2.0 a couple of weeks ago but still have more updates to do to get everything working. |
That sounds great! Is there anything I can do to help you out? Is it on github? |
Yep, it's on GH in a branch... I just need to push the updates I have on my machine. Will let you know once its up and we can go from there. |
Sweet!!! Will you update the nuget package too?? I can update Orchard Core and get it running |
Any updates on this? |
Don't you want to release updates? |
Is there anything a community contributor could do to help get core vLatest support in an ongoing basis? |
Feels like the whole project is offline, even the new edition for node has no updates for some time. And also the domain http://getglimpse.com/ is down. Tooo bad! |
wondering when glimpse will be available for aspnetcore RTM?
The text was updated successfully, but these errors were encountered: