Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

RTM support? #123

Open
joeaudette opened this issue May 26, 2016 · 57 comments
Open

RTM support? #123

joeaudette opened this issue May 26, 2016 · 57 comments

Comments

@joeaudette
Copy link

joeaudette commented May 26, 2016

wondering when glimpse will be available for aspnetcore RTM?

@Noeek
Copy link

Noeek commented Jun 5, 2016

up

@dazinator
Copy link

same - any news on a beta 2?

@avanderhoorn
Copy link
Member

Sorry for the delay in response. We will hopefully have a build of Glimpse out that works on RC2 in the next few weeks. I'll keep this post updated as work progresses. Thanks for your patience!

@joeaudette
Copy link
Author

RTM ships on June 27, so you might as well skip an rc2 version at this point unless it also will support RTM

@avanderhoorn
Copy link
Member

Thats the plan.

@dazinator
Copy link

dazinator commented Jun 22, 2016

Thats the plan.

The problem is, lots of things changed between RC1 and RC2 projects - project.json schema changes, .xproj file changes, global.json file changes, not to mention package and code changes.

Microsoft have said that they will provide an automatic upgrade experience from RC2 based solutions to RTM. Not from RC1.

So I think this will still leave a lot of manual effort to upgrade. I personally have decided to update to RC2, so when RTM tooling ships I can take advantage of the automatic upgrade.

@avanderhoorn
Copy link
Member

The current plan is to update the code to RC2 first, tag it and then start the work for RTM. Depending on the time it takes and if it makes sense, we will release the RC2 version before the RTM.

@dazinator
Copy link

Awesome. Feel free to try my RC1 to RC2 upgrade tool out if you like. https://github.com/dazinator/AspNetRC1toRC2UpgradeTool

@avanderhoorn avanderhoorn changed the title rc2 support? RTM support? Jul 1, 2016
@avanderhoorn
Copy link
Member

Work on this officially starts on Monday. Hopefully wont take more than a week or two. Hard date for completion is the end of the month - there are other things happening which means the work can't go past that. So coming soon :D

@avanderhoorn
Copy link
Member

If you haven't noticed work is starting to be checked in here https://github.com/Glimpse/Glimpse.Prototype/tree/avanderhoorn-rtm-update

@avanderhoorn
Copy link
Member

Well its here. I've got a version of everything updated to be compatible with RTM. If people could try it out and give me feedback on whether everything works as expected, I can get things updated on nuget. Here is the current feed - https://www.myget.org/gallery/glimpseprototype.

@WolfspiritM
Copy link
Contributor

WolfspiritM commented Jul 27, 2016

Thanks!
I tried using it by downloading the MusicStore sample and adding the feed to the nuget.config but it doesn't work correctly for me.
I had to remove dotnet core and needed to compile for net451 cause netcoreapp1.0 gave me:
Can not find compilation library location for package 'Glimpse.Agent.AspNet.Mvc' (might be something on my end?)
For 451: It does compile without errors but when opening the site I just get the glimpse icon on the bottom right but no dashboard (I have to say I'm quiet new to glimpse so not sure if I'm doing everything 100% right):
image

Also when clicking on that icon I get this page:
image
Chrome Javascript console shows twice:

  • Uncaught TypeError: Cannot read property 'ok' of undefined message-repository-remote.js:49

Also I can't see any errors in the Output Window.
Any idea?

@avanderhoorn
Copy link
Member

Thats really weird... I just cloned down music store myself and it ran just fine.

My project.json look like:

  ...
  "dependencies": {
    "Glimpse.Agent.AspNet.Mvc": "2.0.0-beta2-201607261439",
    "Glimpse.Server": "2.0.0-beta2-201607261439",
    ...
  }
  ...

And my startup.cs looks like:

...
using Glimpse;

namespace MusicStore
{
    public class Startup
    {
        ...

        public void ConfigureServices(IServiceCollection services)
        {
            services.AddGlimpse();

            ...
        }

        public void ConfigureDevelopment(IApplicationBuilder app, ILoggerFactory loggerFactory)
        {
            app.UseGlimpse();

            ...
        }

        ...
    }
}

Are you able to confirm that your setup is similar?

@WolfspiritM
Copy link
Contributor

WolfspiritM commented Jul 27, 2016

I have the following as dependency but VS shows me that 2.0.0-beta2-201607261439 is the installed Reference so it should be fine.

    "Glimpse.Agent.AspNet.Mvc": "2.0.0-*",
    "Glimpse.Server": "2.0.0-*",

I can confirm that Startup.cs looks like that.

I now checked a bit what happens. It seems like the result from context is wrongly formatted for me. "$.getJson" is not returning and that makes the HUD completly not render. I then checked the result of:
http://localhost:5000/glimpse/context/?contextId=dcc911aba2e540788469117426011cb1&types=environment%7Cuser-identification%7Cend-request%7Cbegin-request%7Cafter-action-invoked%7Cafter-action-view-invoked%7Cbefore-execute-command%7Cafter-execute-command%7Cafter-view-component

I have no idea why but it seems to return invalid JSON as payload:

...
{
    "id": "0233a1ec5c7c3f22a1e52540157799a2",
    "ordinal": 524,
    "types": ["after-action-invoked"],
    "payload": {
        "actionId": "2d93d149-adba-4fca-a038-4162a6b96558",
        "actionName": "Index",
        "actionControllerName": "Home",
        "actionInvokedEndTime": "2016-07-27T14:47:11.8773171Z",
        "actionInvokedDuration": 27,
        64,
        "actionInvokedOffset": 0,
        76
    },
    "context": {
        "id": "dcc911aba2e540788469117426011cb1",
        "type": "Request"
    }
}
...

I will try later today from another computer and see if it works there.

@avanderhoorn
Copy link
Member

Ya thats really weird... let me know how you get on.

@WolfspiritM
Copy link
Contributor

So after some debugging I think I figured out what the reason for the missing HUD is!
I don't think it has anything to do with the move to RTM as I have never used Glimpse before and it seems like it just would never have worked. So I'm sorry to "spam" this issue with an unrelated problem.
The Reason is that I'm running on a German System.
That means ToString() will convert for example a float 1.2 to "1,2" not "1.2" as json expects it.
The issue is in "Glimpse.Internal.TimeSpanConverter":
https://github.com/Glimpse/Glimpse.Prototype/blob/dev/src/Glimpse.Common/Internal/Serialization/TimeSpanConverter.cs#L18
Right after changing that line to:

writer.WriteRawValue(result.ToString(CultureInfo.InvariantCulture));

Magicly the HUD appears!

There is however still an issue on both of my computers when running with dotnet core AND using the nuget package:

System.InvalidOperationException: Can not find compilation library location for package 'Glimpse.Agent.AspNet.Mvc'

To reproduce this I moved a freshly cloned "MusicStore" to another location outside of the Glimpse src directory (otherwise it will pick up the local files) and added a NuGet.config:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="Glimpse" value="https://www.myget.org/F/glimpseprototype/api/v3/index.json"/>
    <add key="NuGet" value="https://api.nuget.org/v3/index.json" />
  </packageSources>
</configuration>

Then after restore and run it will (at least for me) end up with the error above.
This issue seems to be also tracked in: dotnet/cli#3781

@KoalaBear84
Copy link

This could be the problem as I never got the previous version working on MVC5, Dutch over here. But I do have as much as possible set to English.

I will check the new version out soon.

@WolfspiritM
Copy link
Contributor

WolfspiritM commented Jul 27, 2016

@KoalaBear84 I also have that most things to english but somehow this is set differently.
What helped as a workaround to get the nuget package working (for net451) is:
Region & language settings -> Additional date, time, & regional settings -> Under Region: Change date, time, or number formats -> Formats tab: "Additional settings..." ->Switching the Decimal symbol from "," to "."
Didn't require any reboot or login/logoff. Only the App needed to be restarted of course.

@KoalaBear84
Copy link

Thanks, it looks like the format was still in Dutch. Will work much better in English indeed.

@avanderhoorn
Copy link
Member

WOW!!! Great pickup guys and thanks so much for tracking that down. I would never have guessed that. I'll make the fix and get an update onto the feed hopefully in the next 24hrs or so. Will let everyone know when it goes up. My thinking is that this shouldn't effect people using english based systems.

@CaptainCow95
Copy link

FYI, it looks like you still need to update the main .nuspec file with netstandard entries. It fails to install on a .Net Core application unless you add an import for dnxcore50. The individual packages install fine, it is just the main Glimpse package that doesn't seem to install correctly.

@avanderhoorn
Copy link
Member

@CaptainCow95 good catch, I'll update it as part of the next drop.

@KLuuKer
Copy link

KLuuKer commented Sep 23, 2016

Since miniprofiler has no build for .net core, I would love to see glimpse supporting the rtm build

@karldodd
Copy link

Any updates?

@Jetski5822
Copy link
Contributor

Whats the word chaps, want to plug this in to Orchard 2 and would love an updated nuget package targeting 1.1.0-* if possible.

@avanderhoorn
Copy link
Member

ok... just committed an update to get everything working with the final RTW bits (1.0.). This should also work for 1.1. but I haven't done any explicit testing on that yet. Within the next day or two, I hope to get a updated package published so that we can test those bits before pushing a wider update.

@Jetski5822
Copy link
Contributor

@avanderhoorn I was also updating https://github.com/Jetski5822/Glimpse.Prototype/tree/updatedotnetcore

  • I change it to use the netstandard1.6 so that I could use in Orchard 2
  • Fixed build scripts
  • Fixed the internal abstractions project reference

I was using the xproj stuff so that I can use the global.json project stuff for Orchard2. The branch is also all updated to 1.1.0 too.

Would it be worth me doing PR for this stuff?

@avanderhoorn
Copy link
Member

@Jetski5822 ya take a look at the latest commits I've done and see what the delta is to what you have. I had a little bit of trouble getting the test projects converted over so maybe thats something that you can take a look at. Regardless, let me know what you find and we can go from there. Currently trying to get a build to the feed, but stuck on this one if anyone has any thoughts - https://github.com/dotnet/cli/issues/5151.

@KLuuKer
Copy link

KLuuKer commented Jan 17, 2017

@avanderhoorn i'm not sure but maybe you can take a peek at https://github.com/JimBobSquarePants/ImageSharp
they have builds going with version numbers

hmm they have seemed to create a special project that manages the version numbers (and they still use xproj)

@avanderhoorn
Copy link
Member

Ya ok... Nuget looks like they will have a fix for this issue directly.

@avanderhoorn
Copy link
Member

Good news. I just got things working and I have the building and packing end to end. I managed to get a build that had a patch for the problem I was having and we will be able to get a build out. I'm hoping to have bits up on myget tomorrow!

@Jetski5822
Copy link
Contributor

Jetski5822 commented Jan 20, 2017 via email

@avanderhoorn
Copy link
Member

As a note, I got blocked from putting out the release due to some bug in nuget. Currently working through it.

@avanderhoorn
Copy link
Member

Ok so I've worked around that issue, hit another roadblock in uploading the packages. Hopefully will get this straightened out soon.

@avanderhoorn
Copy link
Member

GREAT NEWS!!! The feed has finally been updated. If you head over to - https://www.myget.org/gallery/glimpseprototype - you will find that 2.0.0-beta2-201701201541 has been deployed. This release includes all the necessary updates to target RTM v1.x.

Note, this update is purely targeted at the infrastructure side of things. Before making further changes I want to make sure we have all our ducks lined up there and that everything continues to work as expected. Once we get that validation I'll be able to move onto the next stage... providing a major update to the client and the data we collect. But before we do that, I need to get the ok on this.

So please take the opportunity to try things out and let me know if you have any thoughts. Additionally thanks for your patients! // @joeaudette, @Noeek, @dazinator, @WolfspiritM, @KoalaBear84, @KLuuKer, @alaatm, @karldodd, @kyurthich, @Jetski5822

@KLuuKer
Copy link

KLuuKer commented Jan 24, 2017

@avanderhoorn i added the brand spanking new beta bits, added the 2 UseGlimpse()'s and....
BAM it just works on my big converted legacy (net461) app

praise god @avanderhoorn

@KoalaBear84
Copy link

KoalaBear84 commented Feb 2, 2017

Thanks. I stopped checking out ASP.NET Core because Glimpse did not work. Now I could start explore it again. I hope it would be sooner because you started working at Microsoft :P

I did the following, as not everyone (myself included) knows how to work with MyGet etc.:

  1. Tools > NuGet Package Manager > Package Manager Settings
  2. Go to Package Sources
  3. Click the green plus sign to add a package source
  4. Enter "https://www.myget.org/F/glimpseprototype/api/v3/index.json"
  5. Select added package source
  6. Click Up arrow button
  7. Click OK to close dialog
  8. Tools > NuGet Package Manager > Package Manager Console
  9. Install-Package Glimpse -pre

Now Glimpse 2.x beta will be included in the project. To use it follow the normal steps:

  1. Open Startup.cs
  2. Add "using Glimpse;" on top
  3. Add "services.AddGlimpse();" in ConfigureServices function
  4. Add "app.UseGlimpse();" in Configure function, BEFORE "app.UseDeveloperExceptionPage();" and "app.UseBrowserLink();"

** EDIT, This exception is not shown if you put it BEFORE :) **

@avanderhoorn The dashboard works, but the Glimpse 'site' (glimpse/client/index.html) does not. Is this a known error?

Here is the exception:

An unhandled exception occurred while processing the request.

InvalidOperationException: Response Content-Length mismatch: too many bytes written (667 of 299).
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame.VerifyAndUpdateWrite(int count)

Stack Query Cookies Headers
InvalidOperationException: Response Content-Length mismatch: too many bytes written (667 of 299).
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame.VerifyAndUpdateWrite(int count)
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Frame+d__183.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.ScriptInjectionFilterStream+<>c__DisplayClass37_0+<b__0>d.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.SocketReader+d__9.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.HttpSocketAdapter+ResponseReader+d__22.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.HttpSocketAdapter+ResponseReader+d__20.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.HttpSocketAdapter+ResponseReader+d__17.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.DelayConnectingHttpSocketAdapter+d__11.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.ScriptInjectionFilterStream+d__14.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.VisualStudio.Web.BrowserLink.BrowserLinkMiddleware+d__7.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware+d__7.MoveNext()

@avanderhoorn
Copy link
Member

@KoalaBear84 Thanks for the writeup that people will be able to use! Re timing, you will find all sorts of interesting things when you join a big company ;) Re this issue... I'm seeing a lot of browser link in there, is there any chance you can comment out browser link and see if that fixe the issue?

@KoalaBear84
Copy link

Great. I didn't disable it. But you have to put it BEFORE "app.UseBrowserLink();" (and also placed it before "app.UseDeveloperExceptionPage();", so Glimpse will process it before it falls in the hands from BrowserLink :D. Thanks! It solved the issue (Y)

@ousiax
Copy link

ousiax commented Sep 18, 2017

Any updates?

@emilianionascu
Copy link

Hi. I'm trying to use Glimpse with an ASP.NET Core 2.0 app and I'm getting the following error:

MissingMethodException: Method not found: 'System.IServiceProvider Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection)'.

Any thoughts on how I could fix this? It looks like Glimpse should reference Microsoft.Extensions.DependencyInjection 2.0.0 or higher.

@dazinator
Copy link

dazinator commented Nov 24, 2017

@ruben-rubio
Copy link

Is the project still active or any updates? because the nuget was not updated with beta2

@KoalaBear84
Copy link

In the beginning of ASP.NET Core I waited and waited, because I wanted Glimpse to be part of the journey of learning / adapting to ASP.NET Core. Also thought that when it was 'acquired' by Microsoft it would get better. But it is a little left behind I guess which is a pity. As it is a really beautiful tool.

@vankooch
Copy link

vankooch commented Dec 21, 2017

Feels like glimpse for .Net is unmaintained, as the developers are working on glimpse for node.js.
See blog post

You may be wondering, “What about Glimpse for .NET?” While we don’t have any announcements to make, I am happy to say that we have been making progress on that front as well. Anthony and I have been quite involved with Diagnostic Source and Activity since their inception, and we see them as cornerstones for a future Glimpse for .NET version. We’ve got a way to go with our Glimpse for Node experiment, but you can rest assured that no matter what happens with it, Microsoft will ship world class diagnostics and debugging tooling for .NET Core.

After watching the code, I guess there is some work to get glimpse working with .net core 2.0. As there is a lot refactoring with Razor and also DiagnosticAdapter has changed.

@avanderhoorn
Copy link
Member

If it helps I am working on this in my spare time... it's just that between everything that's happening I haven't been able to give it as much time as I want. I finished the conversion over to .Net 2.0 a couple of weeks ago but still have more updates to do to get everything working.

@vankooch
Copy link

That sounds great! Is there anything I can do to help you out? Is it on github?

@avanderhoorn
Copy link
Member

Yep, it's on GH in a branch... I just need to push the updates I have on my machine. Will let you know once its up and we can go from there.

@Jetski5822
Copy link
Contributor

Sweet!!! Will you update the nuget package too?? I can update Orchard Core and get it running

@skendrot
Copy link

Any updates on this?

@amirhmi
Copy link

amirhmi commented Aug 25, 2018

Don't you want to release updates?

@sclarson
Copy link

Is there anything a community contributor could do to help get core vLatest support in an ongoing basis?

@vankooch
Copy link

Feels like the whole project is offline, even the new edition for node has no updates for some time. And also the domain http://getglimpse.com/ is down. Tooo bad!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests