Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contentwarehouse): Update tag for create-document.js #3509

Merged
merged 10 commits into from
Oct 3, 2023

Conversation

holtskinner
Copy link
Contributor

- Followup to #3507
- Tag was copied/pasted as `quickstart` when it should have been a new tag
@holtskinner holtskinner requested review from a team as code owners September 22, 2023 14:29
@snippet-bot
Copy link

snippet-bot bot commented Sep 22, 2023

Here is the summary of possible violations 😱

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: contentwarehouse Issues related to the Document AI Warehouse API. samples Issues that are directly related to samples. labels Sep 22, 2023
@holtskinner holtskinner added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 22, 2023
@holtskinner holtskinner added the snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement label Sep 22, 2023
@holtskinner
Copy link
Contributor Author

Is there any way to disable the Snippet Bot check?

@paulinawins
Copy link
Contributor

The tag for this sample code is technically correct. I was following the python sample which simply creates a doc with the content warehouse API. https://cloud.google.com/document-warehouse/docs/samples/contentwarehouse-quickstart?hl=en

The team would prefer to keep this nodeJS sample code together with the python one and not change the tag. Instead, should I rename my file and function name?

@holtskinner
Copy link
Contributor Author

The tag for this sample code is technically correct. I was following the python sample which simply creates a doc with the content warehouse API. https://cloud.google.com/document-warehouse/docs/samples/contentwarehouse-quickstart?hl=en

The team would prefer to keep this nodeJS sample code together with the python one and not change the tag. Instead, should I rename my file and function name?

Thanks for clarifying, I'd recommend changing the file name and function name instead to match the Python sample. I can do that in this same Pull Request and revert my tag change.

@holtskinner holtskinner added snippet-bot:force-run Force snippet-bot runs its logic and removed snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement labels Oct 3, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 3, 2023
Copy link
Contributor

@paulinawins paulinawins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@holtskinner holtskinner merged commit f9fa570 into main Oct 3, 2023
16 of 17 checks passed
@holtskinner holtskinner deleted the docwarehouse-fix branch October 3, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: contentwarehouse Issues related to the Document AI Warehouse API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants