-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(contentwarehouse): Update tag for create-document.js #3509
Conversation
- Followup to #3507 - Tag was copied/pasted as `quickstart` when it should have been a new tag
Here is the summary of possible violations 😱 There is a possible violation for removing region tag in use.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Is there any way to disable the Snippet Bot check? |
The tag for this sample code is technically correct. I was following the python sample which simply creates a doc with the content warehouse API. https://cloud.google.com/document-warehouse/docs/samples/contentwarehouse-quickstart?hl=en The team would prefer to keep this nodeJS sample code together with the python one and not change the tag. Instead, should I rename my file and function name? |
Thanks for clarifying, I'd recommend changing the file name and function name instead to match the Python sample. I can do that in this same Pull Request and revert my tag change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this!
quickstart
when it should have been a new tag