Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gemma2 models samples #3869

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat: gemma2 models samples #3869

merged 4 commits into from
Sep 25, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Sep 20, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj requested review from a team as code owners September 20, 2024 14:36
Copy link

snippet-bot bot commented Sep 20, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: genai labels Sep 20, 2024
@gryczj
Copy link
Contributor Author

gryczj commented Sep 20, 2024

Samples based on GoogleCloudPlatform/python-docs-samples#12598

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2024
@gryczj gryczj self-assigned this Sep 20, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2024
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from product perspective with minor ask.
Please wait for a language review as well before merging.

generative-ai/snippets/test/gemma2Prediction.test.js Outdated Show resolved Hide resolved
@rsamborski rsamborski requested a review from grayside September 24, 2024 09:21
@rsamborski rsamborski assigned grayside and unassigned gryczj Sep 24, 2024
@gryczj gryczj force-pushed the gemma2-models branch 3 times, most recently from 3026609 to 43dde7c Compare September 24, 2024 18:55
@gryczj gryczj requested a review from a team as a code owner September 24, 2024 18:55
@gryczj gryczj added aiplatform Issues related to the AI Platform (Unified) API. and removed api: genai labels Sep 24, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2024
@subfuzion subfuzion enabled auto-merge (squash) September 25, 2024 14:37
@subfuzion subfuzion merged commit beb84f3 into main Sep 25, 2024
7 of 21 checks passed
@subfuzion subfuzion deleted the gemma2-models branch September 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aiplatform Issues related to the AI Platform (Unified) API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants