Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gemini function calling] Fix type annotation for function output in generative-ai/function-calling example #11266

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

koverholt
Copy link
Member

@koverholt koverholt commented Feb 28, 2024

Description

Fixes #11253.

This is a followup PR to #11254 to fix the type annotation in the function output to be a tuple instead of a string.

Also fixes an issue by changing the function role to user role for consistency w/ the Gemini API.

Checklist

@koverholt koverholt requested review from a team as code owners February 28, 2024 21:09
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 28, 2024
@koverholt
Copy link
Member Author

koverholt commented Mar 8, 2024

Apologies, I mixed up my branches and ended up committing the type annotation fix in 72a2f1c in #11257. 😅

But, I also fixed an issue in this PR related to the function vs. user role to be consistent with the Gemini API.

Ping @m-strzelczyk if you're able to review this (small-ish) PR as well.

FYI, tests are passing for the function calling code samples, but failing for others not related to this PR.

@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2024
@kweinmeister kweinmeister merged commit a1e6315 into main Mar 20, 2024
15 checks passed
@kweinmeister kweinmeister deleted the generative-ai-function-calling-types branch March 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
5 participants