Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove 3.12 tests from python 3.7 samples #11406

Merged
merged 6 commits into from
Apr 4, 2024
Merged

chore: remove 3.12 tests from python 3.7 samples #11406

merged 6 commits into from
Apr 4, 2024

Conversation

kweinmeister
Copy link
Contributor

@kweinmeister kweinmeister commented Apr 4, 2024 •
edited
Loading

3.12 tests are running on samples that are only supposed to run on 3.7.

@kweinmeister kweinmeister requested review from a team as code owners April 4, 2024 10:42
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. api: cloudprofiler Issues related to the Cloud Profiler API. labels Apr 4, 2024
rsamborski
rsamborski requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left couple minor comments, but my biggest concern is that this change completely turns off any tests. We're currently running tests in 2.7, 3.8-3.12 while the changes exclude all of these versions.

Is this intended?

appengine/flexible_python37_and_earlier/django_cloudsql/noxfile_config.py Outdated Show resolved Hide resolved
appengine/flexible_python37_and_earlier/scipy/noxfile_config.py Outdated Show resolved Hide resolved
appengine/flexible_python37_and_earlier/storage/noxfile_config.py Outdated Show resolved Hide resolved
appengine/flexible_python37_and_earlier/storage/noxfile_config.py Outdated Show resolved Hide resolved
@kweinmeister
Copy link
Contributor Author

I left couple minor comments, but my biggest concern is that this change completely turns off any tests. We're currently running tests in 2.7, 3.8-3.12 while the changes exclude all of these versions.

Is this intended?

These samples are a duplicated set of the appengine samples used in the docs that only support Python <= 3.7. They have lower dependency versions than the other set of appengine samples supporting 3.8-3.12. Unless we bring back Python 3.7 testing, these will not be tested, which is a separate issue from this PR. We shouldn't be testing these on 3.12 for certain.

@kweinmeister kweinmeister merged commit 1fb70e1 into main Apr 4, 2024
15 checks passed
@kweinmeister kweinmeister deleted the 37earlier branch April 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsamborski rsamborski rsamborski approved these changes

Assignees

@jinglundong jinglundong

Labels
api: appengine Issues related to the App Engine Admin API API. api: cloudprofiler Issues related to the Cloud Profiler API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kweinmeister @rsamborski @jinglundong