Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving issue with regex for composer environments #12581

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

killkelleyr
Copy link
Contributor

@killkelleyr killkelleyr commented Sep 11, 2024

Description

Fixes #12580

Checklist

@killkelleyr killkelleyr requested review from a team as code owners September 11, 2024 14:44
Copy link

google-cla bot commented Sep 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: composer Issues related to the Cloud Composer API. labels Sep 11, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2024
@killkelleyr
Copy link
Contributor Author

killkelleyr commented Sep 12, 2024

Looks like this will require additional changes as it currently produces the following errors since minor and patch are not set.

2024-09-12 14:15:47,029 - Image version: composer-3-airflow-2.9.1-build.6
Traceback (most recent call last):
  File "/home/rkillkelley/composer_dags.py", line 229, in <module>
    main(
  File "/home/rkillkelley/composer_dags.py", line 173, in main
    airflow_version = (int(versions[3]), int(versions[4]), int(versions[5]))
IndexError: tuple index out of range

I will update to ensure minor and patch default to 0

@glasnt glasnt removed their assignment Sep 13, 2024
@iennae
Copy link
Contributor

iennae commented Sep 13, 2024

@killkelleyr thanks for contributing this fix. @leahecole can you take a look?

@leahecole leahecole assigned kosteev and unassigned leahecole Sep 13, 2024
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: composer Issues related to the Cloud Composer API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGEX not matching all composer versions
7 participants