Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(job): delete region tag: create_job at jobs/v3/api_client/base_job_sample.py #12998

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(job): delete region tag: create_job at jobs/v3/api_client/base_job_sample.py #12998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions jobs/v3/api_client/base_job_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ def generate_job_with_required_fields(company_name):


# [START job_create_job]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change removes the create_job region tag. Please confirm that the associated documentation has been updated to reflect this change. If the documentation still references this tag, it will lead to broken links or outdated examples.

# [START create_job]
def create_job(client_service, job_to_be_created):
try:
request = {"job": job_to_be_created}
Expand All @@ -70,7 +69,6 @@ def create_job(client_service, job_to_be_created):
raise e


# [END create_job]
# [END job_create_job]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This removes the closing tag for the create_job snippet. It's crucial to double-check that all corresponding start and end tags are correctly paired and updated across all relevant files. Mismatched or missing tags can cause issues with documentation generation and code examples.



Expand Down