-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(endpoints): migrate regions step 1 - in openapi-appengine.yaml #13016
base: main
Are you sure you want to change the base?
chore(endpoints): migrate regions step 1 - in openapi-appengine.yaml #13016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed:
This PR, chore(endpoints): migrate regions step 1 - in openapi-appengine.yaml
, focuses on migrating regions as part of a larger effort (likely addressing issues b/347825628 and b/347351150). The core change involves updating the openapi.yaml
file within the endpoints/getting-started
directory.
Specifically, the changes are:
-
Added/Updated Comments: The PR adds and modifies comments throughout the
openapi.yaml
file. These comments appear to be adding or updating markers for specific sections of the OpenAPI specification, potentially for documentation or code generation purposes. The changes are consistent and well-formatted.- Lines 15-16, 23-24, 108-109, 117-118, and 165-166 were modified to include
endpoints_swagger_yaml_python
andendpoints_security_definitions_yaml_python
in the comment blocks. - Lines 165-173 were modified to remove the
# [START firebaseAuth]
and# [END firebaseAuth]
comments.
- Lines 15-16, 23-24, 108-109, 117-118, and 165-166 were modified to include
-
No Functional Changes: Importantly, there are no changes to the actual OpenAPI specification itself. This suggests the primary goal is to improve the clarity and maintainability of the documentation within the YAML file.
I'll provide a more detailed review shortly, but this summary should give you a good overview of the changes.
A little haiku to brighten your day:
YAML's gentle flow,
Comments guide the reader's eye,
Clarity takes flight.
Best,
Gemini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request migrates regions in the openapi-appengine.yaml
file. The changes are well-organized and easy to follow. The checklist is complete and indicates that tests and lint checks have passed. I have a few minor suggestions based on the Google Python Style Guide and the provided AUTHORING_GUIDE.md.
Summary of referenced style guide elements:
- Region tags: Region tags should be placed after the license header but before imports and global configurations (AUTHORING_GUIDE.md).
@@ -12,6 +12,7 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
# [START endpoints_swagger_yaml_python] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_swagger_yaml_python
region tag should be placed before the swagger
tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.
# [START endpoints_swagger_yaml_python] | |
# [START swagger] | |
# [START endpoints_swagger_yaml_python] |
@@ -20,6 +21,7 @@ info: | |||
version: "1.0.0" | |||
host: "echo-api.endpoints.YOUR-PROJECT-ID.cloud.goog" | |||
# [END swagger] | |||
# [END endpoints_swagger_yaml_python] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_swagger_yaml_python
region tag should be placed after the swagger
tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.
# [END endpoints_swagger_yaml_python] | |
# [END endpoints_swagger_yaml_python] | |
# [END swagger] |
@@ -103,6 +105,7 @@ definitions: | |||
type: "string" | |||
email: | |||
type: "string" | |||
# [START endpoints_security_definitions_yaml_python] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_security_definitions_yaml_python
region tag should be placed before the securityDef
tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.
# [START endpoints_security_definitions_yaml_python] | |
# [START securityDef] | |
# [START endpoints_security_definitions_yaml_python] |
@@ -111,6 +114,7 @@ securityDefinitions: | |||
name: "key" | |||
in: "query" | |||
# [END securityDef] | |||
# [END endpoints_security_definitions_yaml_python] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_security_definitions_yaml_python
region tag should be placed after the securityDef
tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.
# [END endpoints_security_definitions_yaml_python] | |
# [END endpoints_security_definitions_yaml_python] | |
# [END securityDef] |
firebase: | ||
authorizationUrl: "" | ||
flow: "implicit" | ||
type: "oauth2" | ||
x-google-issuer: "https://securetoken.google.com/YOUR-PROJECT-ID" | ||
x-google-jwks_uri: "https://www.googleapis.com/service_accounts/v1/metadata/x509/[email protected]" | ||
x-google-audiences: "YOUR-PROJECT-ID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Description
Fixes Internal:
b/347825628
b/347351150
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)