Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(endpoints): migrate regions step 1 - in openapi-appengine.yaml #13016

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal:
b/347825628
b/347351150

Checklist

@product-auto-label product-auto-label bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Dec 24, 2024
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed:

This PR, chore(endpoints): migrate regions step 1 - in openapi-appengine.yaml, focuses on migrating regions as part of a larger effort (likely addressing issues b/347825628 and b/347351150). The core change involves updating the openapi.yaml file within the endpoints/getting-started directory.

Specifically, the changes are:

  • Added/Updated Comments: The PR adds and modifies comments throughout the openapi.yaml file. These comments appear to be adding or updating markers for specific sections of the OpenAPI specification, potentially for documentation or code generation purposes. The changes are consistent and well-formatted.

    • Lines 15-16, 23-24, 108-109, 117-118, and 165-166 were modified to include endpoints_swagger_yaml_python and endpoints_security_definitions_yaml_python in the comment blocks.
    • Lines 165-173 were modified to remove the # [START firebaseAuth] and # [END firebaseAuth] comments.
  • No Functional Changes: Importantly, there are no changes to the actual OpenAPI specification itself. This suggests the primary goal is to improve the clarity and maintainability of the documentation within the YAML file.

I'll provide a more detailed review shortly, but this summary should give you a good overview of the changes.


A little haiku to brighten your day:

YAML's gentle flow,
Comments guide the reader's eye,
Clarity takes flight.

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request migrates regions in the openapi-appengine.yaml file. The changes are well-organized and easy to follow. The checklist is complete and indicates that tests and lint checks have passed. I have a few minor suggestions based on the Google Python Style Guide and the provided AUTHORING_GUIDE.md.

Summary of referenced style guide elements:

  • Region tags: Region tags should be placed after the license header but before imports and global configurations (AUTHORING_GUIDE.md).

@@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# [START endpoints_swagger_yaml_python]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_swagger_yaml_python region tag should be placed before the swagger tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.

Suggested change
# [START endpoints_swagger_yaml_python]
# [START swagger]
# [START endpoints_swagger_yaml_python]

@@ -20,6 +21,7 @@ info:
version: "1.0.0"
host: "echo-api.endpoints.YOUR-PROJECT-ID.cloud.goog"
# [END swagger]
# [END endpoints_swagger_yaml_python]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_swagger_yaml_python region tag should be placed after the swagger tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.

Suggested change
# [END endpoints_swagger_yaml_python]
# [END endpoints_swagger_yaml_python]
# [END swagger]

@@ -103,6 +105,7 @@ definitions:
type: "string"
email:
type: "string"
# [START endpoints_security_definitions_yaml_python]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_security_definitions_yaml_python region tag should be placed before the securityDef tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.

Suggested change
# [START endpoints_security_definitions_yaml_python]
# [START securityDef]
# [START endpoints_security_definitions_yaml_python]

@@ -111,6 +114,7 @@ securityDefinitions:
name: "key"
in: "query"
# [END securityDef]
# [END endpoints_security_definitions_yaml_python]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Per the AUTHORING_GUIDE.md, region tags should be placed after the license header but before imports and global configurations. In this case, the endpoints_security_definitions_yaml_python region tag should be placed after the securityDef tag. It's important to maintain consistency and clarity in region tag placement for documentation generation.

Suggested change
# [END endpoints_security_definitions_yaml_python]
# [END endpoints_security_definitions_yaml_python]
# [END securityDef]

Comment on lines 169 to 175
firebase:
authorizationUrl: ""
flow: "implicit"
type: "oauth2"
x-google-issuer: "https://securetoken.google.com/YOUR-PROJECT-ID"
x-google-jwks_uri: "https://www.googleapis.com/service_accounts/v1/metadata/x509/[email protected]"
x-google-audiences: "YOUR-PROJECT-ID"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The firebaseAuth region tags have been removed in this pull request. Please update the documentation to reflect this change. It's important to keep the documentation synchronized with the code.

@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Dec 24, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Dec 24, 2024
Copy link

snippet-bot bot commented Dec 24, 2024

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@eapl-gemugami eapl-gemugami marked this pull request as ready for review December 24, 2024 18:22
@eapl-gemugami eapl-gemugami requested review from a team as code owners December 24, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants