Nightshade patch #163

zeluisping · 2018-01-01T23:29:14Z

Here's a list of changes:

Can no longer change mine while deploying/undeploying
Forced and new third person view while deployed
Arm rotation while deployed
State changing code improved
Beam damage type (fixes the bullet hit sound bug)
Added dust/water effects while uncloaked
Renamed Weap_UT3Nightshade to UT3Weap_NightshadeBeam
Beam gun no longer rotates while deployed

Fixed from #10:

~~Pressing jump button enters deploy mode which does work but doesn't seem you can aim like it is in UT3 (side to side)~~
~~While not invisible on UT3 it has Manta like dust blow under it, not in UT2004 though~~

Fixed from #125:

~~Impact sound of beam weapon is bullet impact sounds in UT2004, doesn't seem to really have an impact sound in UT3 that I can hear~~

Signed-off-by: GreatEmerald <[email protected]>

This should compile now Signed-off-by: GreatEmerald <[email protected]>

Also added the last vehice files from UT3Style Signed-off-by: GreatEmerald <[email protected]>

Signed-off-by: GreatEmerald <[email protected]>

Scorpion's turret is a complete bust without chaning the bones, and the SPMA turret must use the UT2004 system instead of trying to deviate. Signed-off-by: GreatEmerald <[email protected]>

Also adjusted Manta driver seat height Thanks to Parkis G for altering the mesh. Signed-off-by: GreatEmerald <[email protected]>

Thanks to Parkis G for this one as well Signed-off-by: GreatEmerald <[email protected]>

Thanks to Parkis G for the mesh adjustments Signed-off-by: GreatEmerald <[email protected]>

Still needs debugging, though. Oh man, the difficult tasks of eliminating hacks in the original... Signed-off-by: GreatEmerald <[email protected]>

Signed-off-by: GreatEmerald <[email protected]>

Mainly Scorpion driver position and Raptor rudder rotation contstraints Signed-off-by: GreatEmerald <[email protected]>

Updating UT3 Scorpion

Signed-off-by: GreatEmerald <[email protected]>

Turrets are weirdly misaligned for some reason, hmm.. Signed-off-by: GreatEmerald <[email protected]>

Signed-off-by: GreatEmerald <[email protected]>

Things like turret camera offset, exploits where you can fire while deploying, disabling the headlight, getting the volumes right and all that. Signed-off-by: GreatEmerald <[email protected]>

Small stuff, like entry radii, skins, projectiles shooting from the right place and not hurting self etc. Signed-off-by: GreatEmerald <[email protected]>

Now it's less wacky, you can only boost if you have enough speed and are on the ground, the effects are sorted out, and self-destruct now really no longer harms you. Signed-off-by: GreatEmerald <[email protected]>

Manta plasma now has no splash damage, reverted Raptor to be able to hurt itself (can do in UT3 if you try hard enough), and made the Scorpion a bit more lenient with when it allows you to boost.

Truer to the original. Also, it flies now. That's a bug, not intentional, but I'm not too sure how to solve it... Signed-off-by: GreatEmerald <[email protected]>

For now it's to my liking. Signed-off-by: GreatEmerald <[email protected]>

Update suicide string for Viper bolt

Set proper Paladin cannon scaling

…nge code

Unre-Alex · 2018-01-02T01:13:27Z

The dust effect stays after you exit the vehicle, and it should be a little faster, especially when cloaked. Is there a reason why it doesn't rotate its arm 90 degrees?

GreatEmerald

Thanks! Some style comments, however.

GreatEmerald · 2018-01-02T10:15:25Z

Classes/UT3DmgType_NightshadeBeam.uc

+	WeaponClass=class'UT3Weap_NightshadeBeam';
+
+	bDetonatesGoop=true
+    bCausesBlood=false


These need tabs to spaces.

God damnit, need to check my editor settings!

GreatEmerald · 2018-01-02T10:15:53Z

Classes/UT3Nightshade.uc

- * Copyright � 2012 100GPing100
- * Copyright � 2014 GreatEmerald
+ * Copyright � 2012, 2017, 2018 Luís 'zeluisping' Guimarães (100GPing100)
+ * Copyright � 2014 GreatEmerald


The copyright symbols got messed up. Make sure all files are in UTF-8 encoding.

This is weird because that's exactly how it shows in my editor and encoding is set to UTF-8, I even changed to it manually. Gotta figure out what's happening here, thanks for pointing this out!

GreatEmerald · 2018-01-02T10:16:59Z

Classes/UT3Nightshade.uc



+
+simulated function Destroyed() {


I try to keep the style consistent with UT2004, i.e. every { should be on its own line and indents are four spaces rather than a tab.

Sorry on this one, habit kicked in on this one!

GreatEmerald · 2018-01-02T10:17:42Z

Classes/UT3Nightshade.uc

+
+	if (ArmMine != none) {
+		ArmMine.Destroy();
+	}


Braces for single lines are not needed.

Another habit, will change! Think I may have some more that can be removed

GreatEmerald · 2018-01-02T10:18:17Z

Classes/UT3Nightshade.uc

@@ -156,7 +174,7 @@ function bool NoObstacle()
 	else
 		return false;
 }
-/* � Type:
+/* � Type:


This character got messed up too.

That's weird, didn't even know this character was special

GreatEmerald · 2018-01-02T10:19:39Z

Classes/UT3Nightshade.uc

+		if (ShoulderRotation.Yaw <= 32768 && ShoulderRotation.Yaw > 8192) {
+			ShoulderRotation.Yaw = 8192;
+		} else if (ShoulderRotation.Yaw > 32768 && ShoulderRotation.Yaw < 57344) {
+			ShoulderRotation.Yaw = 57344;


It feels like the Clamp functions should be able to handle this with less text.

The thing here is that the clamp value depends on which half of the unit circle the angle is on:

Anything on blue needs to be clamped to 8192 (45º) and anythin on purple needs to be clamped to 57344 (315º).

The only other way I could think of would be to add 8192 (45º) to the angle, this would give me a clamp range from 0 to 16384 (0º to 90º), then after clamping I'd remove the added 8192 (45º). For clarity I left the if approach, but I'd gladly do it this way, in fact I prefer it way more and I can leave a comment of some sort to explain it.

Yea, that would work. Though now we know that the clamping needs to happen at 16k and 48k.

Yes, I'll be changing that too!

GreatEmerald · 2018-01-02T10:21:48Z

Classes/UT3Nightshade.uc

+			break;
+		default:
+			// crash
+			break;


There are no other states, so this will never be run. Instead, you should make VS_Undeployed and VS_Cloaked the default, that will save some lines of code.

GreatEmerald · 2018-01-02T10:23:18Z

Classes/UT3Nightshade.uc

 	}
 }
-function Cloak(bool OnOff)
-{
+function Cloak(bool OnOff) {


Booleans should be prefixed with b and always be positive. In this case it would make sense to call it bCloak.

Okay, but now I feel stupid for not having renamed this variable xD

GreatEmerald · 2018-01-02T10:24:25Z

Classes/UT3Nightshade.uc

-	{
+	local int i;
+
+	if (OnOff == true) {


Using == true is useless and just wastes a CPU cycle, simply remove that part.

Again, force of habit, will change!

GreatEmerald · 2018-01-02T10:25:52Z

Classes/UT3Weap_NightshadeBeam.uc

- * Copyright � 2012 100GPing100
- * Copyright � 2014 GreatEmerald
+ * Copyright � 2012, 2017, 2018 Luís 'zeluisping' Guimarães (100GPing100)
+ * Copyright � 2014 GreatEmerald


Same here, check the encoding

zeluisping · 2018-01-02T10:28:07Z

@Unre-Alex The angle the arm rotates at is clamped to 45º, I used this value from memory thinking it was what happens in UT3, so you say it's 90º? Confirm this for me please and I'll fix it.

Thank you for spotting the dust effects not being destroyed when leaving the vehicle, completely forgot to take care of that!

Regarding the movement speed, the speed while cloaked is a percentage of the speed when not cloaked (just like in UT3 and using the same percentage) so what we can change is the uncloaked speed which will also affect the cloaked speed. Unfortunately I can't fix this one without getting values from you guys, maybe a discussion on #10 or even a different pull request?

HellDragon-HK · 2018-01-02T10:53:25Z

Haven't tried this yet or even really touched the Necris vehicles but the arm is able to move this far in UT3 100GP if you need visual confirmation which can move by mouse or keyboard

GreatEmerald · 2018-01-02T10:54:28Z

The speed values are here:
http://greatemerald.xmpcommunity.com/uncodex/UT3-15/Source_utgame/utvehicle_nightshade.html#62

We've determined that they should match between UT3 and UT2004.

zeluisping · 2018-01-02T10:57:15Z

@HellDragon-HK You can move it with the keyboard? How exactly? 😮 Maybe this can be implemented too (together with the camera constraint that should be implemented at some point). Thank you for the visual confirmations, but it's not really necessary, I trust your word, just need to know if it's confirmed! Thank you!

HellDragon-HK · 2018-01-02T11:09:25Z

That's odd I distinctly remember Forward and Backward keys moving it and it doesn't now, I'm positive I did it that way (Backward moved it left and Forward moved it right) because mouse movement is harder and not as quick but I haven't played since right after the Titan Pack came out and there are a lot of oddities since the Game Spy patch I'm noticing I don't remember

One of those oddities I mentioned is that it likes to almost always spawn me as an Iron Guard Male (which I never use male characters) and none of my keys are what I set them to, I don't use turn left and right I use strafe left and right for example

Unre-Alex · 2018-01-02T14:59:10Z

@100GPing100 Well, as you can see HellDragon confirmed that the arm rotates 90 degrees, I thought there was some issue you couldn't make it work. In UT3, you can rotate it with a mouse or 'turn left' and 'turn right' keys (not strafe keys), which works now in UT2004.

The speed values match UT3? I feel like it's noticeably slower in UT2004. Do you want me to mess with the speed and tell you what I feel is right or do we stay with the current values?

GreatEmerald · 2018-01-02T16:27:18Z

Unless you can find a good enough explanation for why the values should be different, they need to stay as in UT3. They might be modified by the code somewhere, but that means the code needs to be changed to do the same modifications, not the values.

HellDragon-HK · 2018-01-02T16:32:06Z

It's probably not the speed by itself, it's probably in the damping and maxthrust

Also I think I understand why GP thought it turned less, with the mouse it's hard to get it to move as far as it actually can, and it normally only wants to move within what he thought it was

Unre-Alex · 2018-01-02T17:59:21Z

@100GPing100 Two more issues. You can't switch between mines when undeployed and there shouldn't be a shadow when cloaked.

zeluisping · 2018-01-03T11:12:55Z

@Unre-Alex

You can't switch between mines when undeployed

This means we should be able to select mines while undeployed (cloaked and not cloaked but not while deploying/undeploying) or it means we currently can and shouldn't?

@GreatEmerald @HellDragon-HK Since this is a hover vehicle, HellDragon is right and the feeling @Unre-Alex has is valid; most likely what needs to be changed here is the thrust, GroundSpeed, AirSpeed and the KarmaParams's KMaxSpeed should limit the maximum speed properly.

Unre-Alex · 2018-01-03T13:55:26Z

@100GPing100

You don't have UT3 installed right?

This means we should be able to select mines while undeployed (cloaked and not cloaked

Yes, it worked before this patch.

but not while deploying/undeploying)

In UT3 you can select mines while undeploying, and you only can't while deploying.

Also,

The vehicle shouldn't be able to deploy while moving. In UT3 you got the message "Cannot deploy while moving.", you can deploy while moving when cloaked tho (you have the deploy icon all the time).

In UT3 you can deploy while on water (even deep water that would cover the vehicle), it only doesn't let you release the slow field.

zeluisping · 2018-01-03T15:13:35Z

@Unre-Alex Yeah, no UT3 installed because the machine I work on is Linux (and if there is UT3 for linux the specs on this machine aren't enough for that).

That's a lot of useful info! Will take care of applying all that, thank you!

GreatEmerald · 2018-01-03T19:50:26Z

Indeed, UT3 was never released on Linux, so it would only work through Wine.

GreatEmerald and others added 30 commits April 22, 2014 23:21

Addition of animations, conflicts with UT3Style resolved

86026e7

Signed-off-by: GreatEmerald <[email protected]>

Sound import routine alteration, addition of textures and sounds

bf147a4

This should compile now Signed-off-by: GreatEmerald <[email protected]>

Dissolution of the UT3Vehicles.uax file to prevent conflicts

9334ba4

Also added the last vehice files from UT3Style Signed-off-by: GreatEmerald <[email protected]>

Prefix all files with "UT3" to prevent conflicts

0b6b165

Signed-off-by: GreatEmerald <[email protected]>

Semi-fix for the Hellbender and SPMA driving physics

d02c0fa

Signed-off-by: GreatEmerald <[email protected]>

Hellbender and Scorpion physics, SPMA and Scorpion turret adjustment

1e23f2a

Scorpion's turret is a complete bust without chaning the bones, and the SPMA turret must use the UT2004 system instead of trying to deviate. Signed-off-by: GreatEmerald <[email protected]>

Addition of UT3 Hellbender turret meshes

cd757dd

Also adjusted Manta driver seat height Thanks to Parkis G for altering the mesh. Signed-off-by: GreatEmerald <[email protected]>

Fix for Cicada turret meshes

05e8091

Thanks to Parkis G for this one as well Signed-off-by: GreatEmerald <[email protected]>

Updated Paladin and Raptor weapons

a6ad2be

Thanks to Parkis G for the mesh adjustments Signed-off-by: GreatEmerald <[email protected]>

Addition of the second Raptor turret

707f9e9

Still needs debugging, though. Oh man, the difficult tasks of eliminating hacks in the original... Signed-off-by: GreatEmerald <[email protected]>

Fix for Raptor firing and Scorpion mesh

1ecc8f5

Signed-off-by: GreatEmerald <[email protected]>

Fixed some formatting in UT3Scorpion.uc

cae458c

Small alterations to the Scorpion and Raptor

a0919ed

Mainly Scorpion driver position and Raptor rudder rotation contstraints Signed-off-by: GreatEmerald <[email protected]>

Merge pull request #1 from 100GPing100/patch-1

570e2d5

Updating UT3 Scorpion

Adjustments to Raptor and Hellbender looks

939deb7

Signed-off-by: GreatEmerald <[email protected]>

Fix for Hellbender anims, headlights, SPMA mesh updated

844e624

Signed-off-by: GreatEmerald <[email protected]>

Adjustments to the SPMA wheels and balance

6db482d

Signed-off-by: GreatEmerald <[email protected]>

SPMA fixes, Scorpion headlight adjustment

b7d53c1

Signed-off-by: GreatEmerald <[email protected]>

Addition of the Leviathan mesh

53aa912

Signed-off-by: GreatEmerald <[email protected]>

Addition of Leviathan sounds, main and driver turret

9df3af5

Signed-off-by: GreatEmerald <[email protected]>

Adjustment of Leviathan sounds, addition of turret meshes

9e7392f

Turrets are weirdly misaligned for some reason, hmm.. Signed-off-by: GreatEmerald <[email protected]>

Leviathan deploy via space, secondary fire zooms

8922b80

Signed-off-by: GreatEmerald <[email protected]>

Hack for Leviathan wheel fender rotation

b7cdd8e

Signed-off-by: GreatEmerald <[email protected]>

Fix for cannon appearance, fix for side turrets not animating

686e531

Signed-off-by: GreatEmerald <[email protected]>

Leviathan fixes

4f52086

Things like turret camera offset, exploits where you can fire while deploying, disabling the headlight, getting the volumes right and all that. Signed-off-by: GreatEmerald <[email protected]>

Assorted Leviathan, Manta and Raptor fixes

7284757

Small stuff, like entry radii, skins, projectiles shooting from the right place and not hurting self etc. Signed-off-by: GreatEmerald <[email protected]>

Adjustments to Scorpion's boosting abilities

101da5c

Now it's less wacky, you can only boost if you have enough speed and are on the ground, the effects are sorted out, and self-destruct now really no longer harms you. Signed-off-by: GreatEmerald <[email protected]>

Small tweaks to get closer to the original

616a46b

Manta plasma now has no splash damage, reverted Raptor to be able to hurt itself (can do in UT3 if you try hard enough), and made the Scorpion a bit more lenient with when it allows you to boost.

Adjustments to the Scorpion handling

112684f

Truer to the original. Also, it flies now. That's a bug, not intentional, but I'm not too sure how to solve it... Signed-off-by: GreatEmerald <[email protected]>

Fix for the remaining Scorpion issues

22f3c97

For now it's to my liking. Signed-off-by: GreatEmerald <[email protected]>

GreatEmerald and others added 12 commits December 31, 2017 15:59

Merge pull request GreatEmerald#153 from HellDragon-HK/patch-5

c808a74

Update suicide string for Viper bolt

Merge pull request GreatEmerald#161 from HellDragon-HK/patch-43

63aea52

Set proper Paladin cannon scaling

Nightshade: can no longer change mine while deploying

2a9a825

Nightshade: deployed 3rd person view, arm rotates; improved state cha…

81438ab

…nge code

Nightshade: Added beam damage type (fixes hit sound)

3e459d7

Nightshade: destroy arm mine when destroyed

3e902e7

Nightshade: added dust/water effect (unclocked)

6b9f952

NIghtshade: fixed arm rotation (clamp)

e3f9cf3

Nightshade: single dust effect

dd6502c

Nightshade: fix copyright; renamed weapon class

df18d7a

Nightshade: some changes are actually from 2018

5b4a447

Nightshade: This one is 2018 only

cb0ba58

GreatEmerald requested changes Jan 2, 2018

View reviewed changes

GreatEmerald added the Work in progress label Jan 3, 2018

GreatEmerald force-pushed the master branch from 876875b to 9a4ea30 Compare January 3, 2018 20:26

GreatEmerald added the Stale label Jan 3, 2018

Nightshade patch #163

Are you sure you want to change the base?

Nightshade patch #163

Conversation

zeluisping commented Jan 1, 2018

Unre-Alex commented Jan 2, 2018

GreatEmerald left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zeluisping Jan 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zeluisping commented Jan 2, 2018

HellDragon-HK commented Jan 2, 2018

GreatEmerald commented Jan 2, 2018

zeluisping commented Jan 2, 2018

HellDragon-HK commented Jan 2, 2018 • edited Loading

Unre-Alex commented Jan 2, 2018

GreatEmerald commented Jan 2, 2018

HellDragon-HK commented Jan 2, 2018

Unre-Alex commented Jan 2, 2018

zeluisping commented Jan 3, 2018 • edited Loading

Unre-Alex commented Jan 3, 2018 • edited Loading

zeluisping commented Jan 3, 2018

GreatEmerald commented Jan 3, 2018

zeluisping Jan 2, 2018 •

edited

Loading

HellDragon-HK commented Jan 2, 2018 •

edited

Loading

zeluisping commented Jan 3, 2018 •

edited

Loading

Unre-Alex commented Jan 3, 2018 •

edited

Loading