Skip to content

Commit

Permalink
remove obsolete MapApp component (#712)
Browse files Browse the repository at this point in the history
* remove obsolete MapApp component

* fix storybook build

See storybookjs/storybook#30115

* fix storybook

* fix storybook

* fix storybook

* fix storybook

* update install steps in other workflows

* lint
  • Loading branch information
jamesscottbrown authored Dec 20, 2024
1 parent a3726bf commit 530d8de
Show file tree
Hide file tree
Showing 16 changed files with 11,390 additions and 18,258 deletions.
5 changes: 5 additions & 0 deletions .changeset/delete-mapapp.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ldn-viz/maps': major
---

REMOVED: removed `MappApp` component, which was replaced by `AppShell`
4 changes: 2 additions & 2 deletions .github/workflows/deploy-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Deploy branch preview of storybook site to Pages

on:
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
Expand All @@ -17,7 +17,7 @@ jobs:
cache: npm

- name: Install dependencies
run: npm install --ignore-scripts esbuild && npm install @rollup/rollup-linux-x64-gnu
run: npm install

# if we don't do this, imports between packages will fail
# (e.g., import of Button from @ldn-viz/ui into @ldn-viz/charts)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-storybook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ jobs:
cache: npm

- name: Install dependencies
run: npm install --ignore-scripts esbuild && npm install @rollup/rollup-linux-x64-gnu
run: npm install

# if we don't do this, imports between packages will fail
# (e.g., import of Button from @ldn-viz/ui into @ldn-viz/charts)
- name: Build everything
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
cache: npm

- name: Install dependencies
run: npm install --ignore-scripts esbuild && npm install @rollup/rollup-linux-x64-gnu
run: npm install

- name: Lint
run: npm run lint
Loading

0 comments on commit 530d8de

Please sign in to comment.