Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #1729

Merged
merged 6 commits into from
Oct 16, 2023
Merged

V2 #1729

merged 6 commits into from
Oct 16, 2023

Conversation

DylanJG01
Copy link
Member

Description

comment: # Changes to cypress integration tests so they now pass. Change to .env.developement.

Fixes # 1724

Type of change: Refactoring.

Screenshots

After
Screenshot 2023-10-12 120229

How Has This Been Tested?

  • Cypress integration

Checklist:

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@DylanJG01
Copy link
Member Author

I consider this significant progress. I shall now fix what is wrong with the unit test.

@dadiorchen
Copy link
Collaborator

@DylanJG01 yes, there is a unit test failed, please check it.

@DylanJG01
Copy link
Member Author

Solved.

@dadiorchen
Copy link
Collaborator

@DylanJG01 thank you!

@dadiorchen dadiorchen merged commit e43080a into Greenstand:v2 Oct 16, 2023
3 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.6.0-v2.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants