-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eject expo to rn #19
Open
pierrelstan
wants to merge
3
commits into
master
Choose a base branch
from
eject-expo-to-rn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Eject expo to rn #19
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# OSX | ||
# | ||
.DS_Store | ||
|
||
# Android/IntelliJ | ||
# | ||
build/ | ||
.idea | ||
.gradle | ||
local.properties | ||
*.iml | ||
*.hprof | ||
|
||
# Bundle artifacts | ||
*.jsbundle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,237 @@ | ||
apply plugin: "com.android.application" | ||
apply plugin: "com.facebook.react" | ||
|
||
import com.android.build.OutputFile | ||
|
||
def projectRoot = rootDir.getAbsoluteFile().getParentFile().getAbsolutePath() | ||
def expoDebuggableVariants = ['debug'] | ||
// Override `debuggableVariants` for expo-updates debugging | ||
if (System.getenv('EX_UPDATES_NATIVE_DEBUG') == "1") { | ||
react { | ||
expoDebuggableVariants = [] | ||
} | ||
} | ||
|
||
|
||
/** | ||
* This is the configuration block to customize your React Native Android app. | ||
* By default you don't need to apply any configuration, just uncomment the lines you need. | ||
*/ | ||
react { | ||
entryFile = file(["node", "-e", "require('expo/scripts/resolveAppEntry')", projectRoot, "android", "absolute"].execute(null, rootDir).text.trim()) | ||
reactNativeDir = new File(["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim()).getParentFile().getAbsoluteFile() | ||
hermesCommand = new File(["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim()).getParentFile().getAbsolutePath() + "/sdks/hermesc/%OS-BIN%/hermesc" | ||
debuggableVariants = expoDebuggableVariants | ||
|
||
/* Folders */ | ||
// The root of your project, i.e. where "package.json" lives. Default is '..' | ||
// root = file("../") | ||
// The folder where the react-native NPM package is. Default is ../node_modules/react-native | ||
// reactNativeDir = file("../node_modules/react-native") | ||
// The folder where the react-native Codegen package is. Default is ../node_modules/react-native-codegen | ||
// codegenDir = file("../node_modules/react-native-codegen") | ||
// The cli.js file which is the React Native CLI entrypoint. Default is ../node_modules/react-native/cli.js | ||
// cliFile = file("../node_modules/react-native/cli.js") | ||
|
||
/* Variants */ | ||
// The list of variants to that are debuggable. For those we're going to | ||
// skip the bundling of the JS bundle and the assets. By default is just 'debug'. | ||
// If you add flavors like lite, prod, etc. you'll have to list your debuggableVariants. | ||
// debuggableVariants = ["liteDebug", "prodDebug"] | ||
|
||
/* Bundling */ | ||
// A list containing the node command and its flags. Default is just 'node'. | ||
// nodeExecutableAndArgs = ["node"] | ||
// | ||
// The command to run when bundling. By default is 'bundle' | ||
// bundleCommand = "ram-bundle" | ||
// | ||
// The path to the CLI configuration file. Default is empty. | ||
// bundleConfig = file(../rn-cli.config.js) | ||
// | ||
// The name of the generated asset file containing your JS bundle | ||
// bundleAssetName = "MyApplication.android.bundle" | ||
// | ||
// The entry file for bundle generation. Default is 'index.android.js' or 'index.js' | ||
// entryFile = file("../js/MyApplication.android.js") | ||
// | ||
// A list of extra flags to pass to the 'bundle' commands. | ||
// See https://github.com/react-native-community/cli/blob/main/docs/commands.md#bundle | ||
// extraPackagerArgs = [] | ||
|
||
/* Hermes Commands */ | ||
// The hermes compiler command to run. By default it is 'hermesc' | ||
// hermesCommand = "$rootDir/my-custom-hermesc/bin/hermesc" | ||
// | ||
// The list of flags to pass to the Hermes compiler. By default is "-O", "-output-source-map" | ||
// hermesFlags = ["-O", "-output-source-map"] | ||
} | ||
|
||
// Override `hermesEnabled` by `expo.jsEngine` | ||
ext { | ||
hermesEnabled = (findProperty('expo.jsEngine') ?: "hermes") == "hermes" | ||
} | ||
|
||
/** | ||
* Set this to true to create four separate APKs instead of one, | ||
* one for each native architecture. This is useful if you don't | ||
* use App Bundles (https://developer.android.com/guide/app-bundle/) | ||
* and want to have separate APKs to upload to the Play Store. | ||
*/ | ||
def enableSeparateBuildPerCPUArchitecture = false | ||
|
||
/** | ||
* Set this to true to Run Proguard on Release builds to minify the Java bytecode. | ||
*/ | ||
def enableProguardInReleaseBuilds = (findProperty('android.enableProguardInReleaseBuilds') ?: false).toBoolean() | ||
|
||
/** | ||
* The preferred build flavor of JavaScriptCore (JSC) | ||
* | ||
* For example, to use the international variant, you can use: | ||
* `def jscFlavor = 'org.webkit:android-jsc-intl:+'` | ||
* | ||
* The international variant includes ICU i18n library and necessary data | ||
* allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that | ||
* give correct results when using with locales other than en-US. Note that | ||
* this variant is about 6MiB larger per architecture than default. | ||
*/ | ||
def jscFlavor = 'org.webkit:android-jsc:+' | ||
|
||
/** | ||
* Private function to get the list of Native Architectures you want to build. | ||
* This reads the value from reactNativeArchitectures in your gradle.properties | ||
* file and works together with the --active-arch-only flag of react-native run-android. | ||
*/ | ||
def reactNativeArchitectures() { | ||
def value = project.getProperties().get("reactNativeArchitectures") | ||
return value ? value.split(",") : ["armeabi-v7a", "x86", "x86_64", "arm64-v8a"] | ||
} | ||
|
||
android { | ||
ndkVersion rootProject.ext.ndkVersion | ||
|
||
compileSdkVersion rootProject.ext.compileSdkVersion | ||
|
||
namespace 'com.greenstand.treetrackerwebmapcorern' | ||
defaultConfig { | ||
applicationId 'com.greenstand.treetrackerwebmapcorern' | ||
minSdkVersion rootProject.ext.minSdkVersion | ||
targetSdkVersion rootProject.ext.targetSdkVersion | ||
versionCode 1 | ||
versionName "1.0.0" | ||
} | ||
|
||
splits { | ||
abi { | ||
reset() | ||
enable enableSeparateBuildPerCPUArchitecture | ||
universalApk false // If true, also generate a universal APK | ||
include (*reactNativeArchitectures()) | ||
} | ||
} | ||
signingConfigs { | ||
debug { | ||
storeFile file('debug.keystore') | ||
storePassword 'android' | ||
keyAlias 'androiddebugkey' | ||
keyPassword 'android' | ||
} | ||
} | ||
buildTypes { | ||
debug { | ||
signingConfig signingConfigs.debug | ||
} | ||
release { | ||
// Caution! In production, you need to generate your own keystore file. | ||
// see https://reactnative.dev/docs/signed-apk-android. | ||
signingConfig signingConfigs.debug | ||
shrinkResources (findProperty('android.enableShrinkResourcesInReleaseBuilds')?.toBoolean() ?: false) | ||
minifyEnabled enableProguardInReleaseBuilds | ||
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro" | ||
} | ||
} | ||
|
||
// applicationVariants are e.g. debug, release | ||
applicationVariants.all { variant -> | ||
variant.outputs.each { output -> | ||
// For each separate APK per architecture, set a unique version code as described here: | ||
// https://developer.android.com/studio/build/configure-apk-splits.html | ||
// Example: versionCode 1 will generate 1001 for armeabi-v7a, 1002 for x86, etc. | ||
def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4] | ||
def abi = output.getFilter(OutputFile.ABI) | ||
if (abi != null) { // null for the universal-debug, universal-release variants | ||
output.versionCodeOverride = | ||
defaultConfig.versionCode * 1000 + versionCodes.get(abi) | ||
} | ||
|
||
} | ||
} | ||
} | ||
|
||
// Apply static values from `gradle.properties` to the `android.packagingOptions` | ||
// Accepts values in comma delimited lists, example: | ||
// android.packagingOptions.pickFirsts=/LICENSE,**/picasa.ini | ||
["pickFirsts", "excludes", "merges", "doNotStrip"].each { prop -> | ||
// Split option: 'foo,bar' -> ['foo', 'bar'] | ||
def options = (findProperty("android.packagingOptions.$prop") ?: "").split(","); | ||
// Trim all elements in place. | ||
for (i in 0..<options.size()) options[i] = options[i].trim(); | ||
// `[] - ""` is essentially `[""].filter(Boolean)` removing all empty strings. | ||
options -= "" | ||
|
||
if (options.length > 0) { | ||
println "android.packagingOptions.$prop += $options ($options.length)" | ||
// Ex: android.packagingOptions.pickFirsts += '**/SCCS/**' | ||
options.each { | ||
android.packagingOptions[prop] += it | ||
} | ||
} | ||
} | ||
|
||
dependencies { | ||
// The version of react-native is set by the React Native Gradle Plugin | ||
implementation("com.facebook.react:react-android") | ||
|
||
def isGifEnabled = (findProperty('expo.gif.enabled') ?: "") == "true"; | ||
def isWebpEnabled = (findProperty('expo.webp.enabled') ?: "") == "true"; | ||
def isWebpAnimatedEnabled = (findProperty('expo.webp.animated') ?: "") == "true"; | ||
def frescoVersion = rootProject.ext.frescoVersion | ||
|
||
// If your app supports Android versions before Ice Cream Sandwich (API level 14) | ||
if (isGifEnabled || isWebpEnabled) { | ||
implementation("com.facebook.fresco:fresco:${frescoVersion}") | ||
implementation("com.facebook.fresco:imagepipeline-okhttp3:${frescoVersion}") | ||
} | ||
|
||
if (isGifEnabled) { | ||
// For animated gif support | ||
implementation("com.facebook.fresco:animated-gif:${frescoVersion}") | ||
} | ||
|
||
if (isWebpEnabled) { | ||
// For webp support | ||
implementation("com.facebook.fresco:webpsupport:${frescoVersion}") | ||
if (isWebpAnimatedEnabled) { | ||
// Animated webp support | ||
implementation("com.facebook.fresco:animated-webp:${frescoVersion}") | ||
} | ||
} | ||
|
||
implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.0.0") | ||
|
||
debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") | ||
debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") { | ||
exclude group:'com.squareup.okhttp3', module:'okhttp' | ||
} | ||
debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}") | ||
|
||
if (hermesEnabled.toBoolean()) { | ||
implementation("com.facebook.react:hermes-android") | ||
} else { | ||
implementation jscFlavor | ||
} | ||
} | ||
|
||
apply from: new File(["node", "--print", "require.resolve('@react-native-community/cli-platform-android/package.json')"].execute(null, rootDir).text.trim(), "../native_modules.gradle"); | ||
applyNativeModulesAppBuildGradle(project) |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Add project specific ProGuard rules here. | ||
# By default, the flags in this file are appended to flags specified | ||
# in /usr/local/Cellar/android-sdk/24.3.3/tools/proguard/proguard-android.txt | ||
# You can edit the include path and order by changing the proguardFiles | ||
# directive in build.gradle. | ||
# | ||
# For more details, see | ||
# http://developer.android.com/guide/developing/tools/proguard.html | ||
|
||
# react-native-reanimated | ||
-keep class com.swmansion.reanimated.** { *; } | ||
-keep class com.facebook.react.turbomodule.** { *; } | ||
|
||
# Add any project specific keep options here: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:tools="http://schemas.android.com/tools"> | ||
|
||
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> | ||
|
||
<application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning" /> | ||
</manifest> |
75 changes: 75 additions & 0 deletions
75
android/app/src/debug/java/com/greenstand/treetrackerwebmapcorern/ReactNativeFlipper.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* <p>This source code is licensed under the MIT license found in the LICENSE file in the root | ||
* directory of this source tree. | ||
*/ | ||
package com.greenstand.treetrackerwebmapcorern; | ||
|
||
import android.content.Context; | ||
import com.facebook.flipper.android.AndroidFlipperClient; | ||
import com.facebook.flipper.android.utils.FlipperUtils; | ||
import com.facebook.flipper.core.FlipperClient; | ||
import com.facebook.flipper.plugins.crashreporter.CrashReporterPlugin; | ||
import com.facebook.flipper.plugins.databases.DatabasesFlipperPlugin; | ||
import com.facebook.flipper.plugins.fresco.FrescoFlipperPlugin; | ||
import com.facebook.flipper.plugins.inspector.DescriptorMapping; | ||
import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin; | ||
import com.facebook.flipper.plugins.network.FlipperOkhttpInterceptor; | ||
import com.facebook.flipper.plugins.network.NetworkFlipperPlugin; | ||
import com.facebook.flipper.plugins.sharedpreferences.SharedPreferencesFlipperPlugin; | ||
import com.facebook.react.ReactInstanceEventListener; | ||
import com.facebook.react.ReactInstanceManager; | ||
import com.facebook.react.bridge.ReactContext; | ||
import com.facebook.react.modules.network.NetworkingModule; | ||
import okhttp3.OkHttpClient; | ||
|
||
/** | ||
* Class responsible of loading Flipper inside your React Native application. This is the debug | ||
* flavor of it. Here you can add your own plugins and customize the Flipper setup. | ||
*/ | ||
public class ReactNativeFlipper { | ||
public static void initializeFlipper(Context context, ReactInstanceManager reactInstanceManager) { | ||
if (FlipperUtils.shouldEnableFlipper(context)) { | ||
final FlipperClient client = AndroidFlipperClient.getInstance(context); | ||
|
||
client.addPlugin(new InspectorFlipperPlugin(context, DescriptorMapping.withDefaults())); | ||
client.addPlugin(new DatabasesFlipperPlugin(context)); | ||
client.addPlugin(new SharedPreferencesFlipperPlugin(context)); | ||
client.addPlugin(CrashReporterPlugin.getInstance()); | ||
|
||
NetworkFlipperPlugin networkFlipperPlugin = new NetworkFlipperPlugin(); | ||
NetworkingModule.setCustomClientBuilder( | ||
new NetworkingModule.CustomClientBuilder() { | ||
@Override | ||
public void apply(OkHttpClient.Builder builder) { | ||
builder.addNetworkInterceptor(new FlipperOkhttpInterceptor(networkFlipperPlugin)); | ||
} | ||
}); | ||
client.addPlugin(networkFlipperPlugin); | ||
client.start(); | ||
|
||
// Fresco Plugin needs to ensure that ImagePipelineFactory is initialized | ||
// Hence we run if after all native modules have been initialized | ||
ReactContext reactContext = reactInstanceManager.getCurrentReactContext(); | ||
if (reactContext == null) { | ||
reactInstanceManager.addReactInstanceEventListener( | ||
new ReactInstanceEventListener() { | ||
@Override | ||
public void onReactContextInitialized(ReactContext reactContext) { | ||
reactInstanceManager.removeReactInstanceEventListener(this); | ||
reactContext.runOnNativeModulesQueueThread( | ||
new Runnable() { | ||
@Override | ||
public void run() { | ||
client.addPlugin(new FrescoFlipperPlugin()); | ||
} | ||
}); | ||
} | ||
}); | ||
} else { | ||
client.addPlugin(new FrescoFlipperPlugin()); | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But @pierrelstan after ejection, we don't need expo anymore right? what's the command to start the project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need the expo. The only difference is that when we prebuild the Expo app, we can customize the Android and Ios native apps.
According to the documentation, after prebuild the project, that is how to build the native apps locally.
https://docs.expo.dev/workflow/prebuild/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got it, thank you