Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TagPrefix-based Recipe Generation #2616

Open
wants to merge 3 commits into
base: 1.20.1
Choose a base branch
from

Conversation

TechLord22
Copy link
Member

@TechLord22 TechLord22 commented Dec 21, 2024

What

Improves TagPrefix-based Recipe Generation. Notably, this PR no longer iterates all materials for every registration handler. Instead, materials are only iterated once.

Also, fixes a bug where ores of gem materials would not forge hammer to the gem if the material had an ignored gem.

Implementation Details

Outcome

Improves performance and cleans up recipe generation code.

@TechLord22 TechLord22 requested a review from a team as a code owner December 21, 2024 21:47
@TechLord22 TechLord22 added Do Not Merge DO NOT MERGE THIS PR YET! type: refactor Suggestion to refactor a section of code labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge DO NOT MERGE THIS PR YET! type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant