Improve TagPrefix-based Recipe Generation #2616
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves TagPrefix-based Recipe Generation. Notably, this PR no longer iterates all materials for every registration handler. Instead, materials are only iterated once.
Also, fixes a bug where ores of gem materials would not forge hammer to the gem if the material had an ignored gem.
Implementation Details
GTUtil.copyAmount
andGTUtil.selectItemInList
to begin with.TagPrefix.MaterialRecipeHandler
andTagPrefix#executeHandler
. This will require addons to update, and this PR serves as an example of how to do so.Outcome
Improves performance and cleans up recipe generation code.