Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add High Pressure Variation of The Steam Miner Singleblock. #2637

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

Ghostipedia
Copy link
Member

@Ghostipedia Ghostipedia commented Dec 24, 2024

What

Miner, but High pressure. Yeah

Mines an ore every 12s and has a range of 13x13

Context
LP ; 9x9 @ 16s @ 16 steam/t
HP ; 13x13 @ 12s
LV ; 15x15 @ 8s

Could have opt'd for an 11x11 range, but i felt the increased steam cost was slightly justifying 13x13 (Obviously, it is double that of LP)

People Expressed a want for another miner because of how poor the range on the steam miner is even though it's useful due to moderns generation. So here that is, i guess

@Ghostipedia Ghostipedia requested a review from a team as a code owner December 24, 2024 17:34
@Ghostipedia Ghostipedia added the type: feature New feature or request label Dec 24, 2024
Copy link
Member

@screret screret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just do it like the steam macerator for example, with the registerSteamMachines helper.

@jtuc
Copy link
Contributor

jtuc commented Dec 25, 2024

Tested Datafixer, BlockEntity, block and item all appear to be mapped correctly.
2024-12-25_15 25 14

[15:22:54] [Render thread/INFO] [ne.mi.re.ForgeRegistry/REGISTRIES]: Registry minecraft:block: Found a missing id from the world gtceu:steam_miner
[15:22:54] [Render thread/INFO] [ne.mi.re.ForgeRegistry/REGISTRIES]: Registry minecraft:item: Found a missing id from the world gtceu:steam_miner
...
[15:23:10] [Server thread/WARN] [minecraft/BlockEntity]: Skipping BlockEntity with id gtceu:steam_miner
[15:23:10] [Server thread/WARN] [minecraft/BlockEntity]: Skipping BlockEntity with id gtceu:steam_miner

@Ghostipedia Ghostipedia enabled auto-merge (squash) December 27, 2024 02:56
@krossgg krossgg requested a review from screret December 27, 2024 02:59
@Ghostipedia Ghostipedia merged commit ca303c5 into 1.20.1 Dec 27, 2024
2 checks passed
@Ghostipedia Ghostipedia deleted the gp/high-pressure-miner branch December 27, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants