Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laser Overhaul #2082

Merged
merged 21 commits into from
Oct 11, 2023
Merged

Laser Overhaul #2082

merged 21 commits into from
Oct 11, 2023

Conversation

htmlcsjs
Copy link
Member

@htmlcsjs htmlcsjs commented Sep 16, 2023 •
edited
Loading

What

  • laser hatches now have buffers
    • laser hatches have top integration now
    • they have multiple tiers and amperage levels (IV+ and 256/1024/4096A)
  • the AT now can have multiple laser hatches
  • the AT now can have substation hatch

Outcome

The laser system is much less wack now

Potential Compatibility Issues

people's laser hatches are probably gone

@htmlcsjs htmlcsjs requested a review from a team as a code owner September 16, 2023 20:33
@htmlcsjs
changes to AT hatches limits:
b12b4ec 
- can use substation ones
- can have more than one laser hatch
- no more maintenance
@htmlcsjs
🦀 buffers are back 🦀
a7c8c9a 
- many more hatches
- """working""" at logic
@htmlcsjs
fix issues relating to me not being able to type code
803bbc2 
- now forms correctly and has correct logic for multiblock validity checking
@htmlcsjs
add lang
b528f4e
@htmlcsjs
actually get pushing energy working (at least without pipes)
fe656b4
@htmlcsjs
add top support
d295499
@htmlcsjs
fix setactive not wotrking properly
0cb5c1f
@htmlcsjs htmlcsjs changed the title Allow power substation input hatches in the active transformer Laser Overhaul Sep 30, 2023
@htmlcsjs htmlcsjs added status: high priority Issue or PR should be prioritized for reviews type: refactor Suggestion to refactor a section of code labels Sep 30, 2023
@serenibyss
Copy link
Member

I think they should overvolt if you connect a zpm laser source to a luv laser target, I thought about it more and think this is important. Otherwise this PR looks great

@htmlcsjs
Copy link
Member Author

I think they should overvolt if you connect a zpm laser source to a luv laser target, I thought about it more and think this is important. Otherwise this PR looks great

do you mean any higher teir or one where the src voltage * src amperage > target voltage * target amperage

@serenibyss serenibyss merged commit a3844dd into master Oct 11, 2023
3 checks passed
@serenibyss serenibyss deleted the ht-laser-subsation-hatch branch October 11, 2023 07:42
MrKono added a commit to MrKono/GregTech that referenced this pull request Oct 13, 2023
@MrKono
[Apply] GregTechCEu#2082
a07cb96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
status: high priority Issue or PR should be prioritized for reviews type: refactor Suggestion to refactor a section of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htmlcsjs @serenibyss