Refactor FluidTankList and Filtered Handlers #2690
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entry is not a handler
rename misc
why check for handler
comments
rename and rework IFilteredHandler for item handlers as well deprecate some classes
ghzdude
commented
Dec 27, 2024
Comment on lines
-105
to
-107
| if (!(fluidTank instanceof IFluidHandler)) | ||
| throw new IllegalStateException( | ||
| "Container IO is only supported for fluid tanks that implement IFluidHandler"); |
There was a problem hiding this comment.
i do not know why this check was needed, as it's never required to be an IFluidHandler in the class.
either way, it'll be handled properly in the mui2 port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
refactor/simplify fluid tank list
potentially fixes an issue when nesting fluid tanks with differing same fluid fill
yeet overlayed fluid handler because it was redundant
add filtering to base gt item/fluid handlers
Implementation Details
IMultipleTankHandler is now an abstract class
FluidTankList is now final
IFilteredHandler has a generic to set IFilter
notifiable fluid lists are now IFluidTank instead of handler (usually tanks are passed in, and i haven't observed any immediate issues)
Outcome
fluid tank list somewhat less sussy
Potential Compatibility Issues
a handful of classes are now deprecated, but they should still function for now