Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add time features to getting started doc of playground #353

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

nicecui
Copy link
Contributor

@nicecui nicecui commented Nov 18, 2023

No description provided.

Copy link

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengjiachun @waynexia PTAL. We also need to ensure these examples run at good performance, and match our design purpose.

src/views/dashboard/playground/docs/getting-started.md Outdated Show resolved Hide resolved
src/views/dashboard/playground/docs/getting-started.md Outdated Show resolved Hide resolved
src/views/dashboard/playground/docs/getting-started.md Outdated Show resolved Hide resolved
src/views/dashboard/playground/docs/getting-started.md Outdated Show resolved Hide resolved
@sunng87 sunng87 enabled auto-merge (squash) November 21, 2023 03:22
auto-merge was automatically disabled November 22, 2023 03:05

Head branch was pushed to by a user without write access

@waynexia waynexia enabled auto-merge (squash) November 22, 2023 03:08
@waynexia waynexia requested a review from fengjiachun November 22, 2023 03:08
@paomian paomian requested review from fengjiachun and removed request for fengjiachun November 22, 2023 07:03
auto-merge was automatically disabled November 22, 2023 07:12

Head branch was pushed to by a user without write access

Copy link

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alili alili merged commit 35a761c into GreptimeTeam:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants