chore: follow review comments

GreptimeTeam · Dec 26, 2024 · a82b7d9 · a82b7d9
1 parent c03ab3c
commit a82b7d9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/src/common/meta/src/kv_backend/postgres.rs b/src/common/meta/src/kv_backend/postgres.rs
@@ -16,6 +16,7 @@ use std::any::Any;
 use std::borrow::Cow;
 use std::sync::Arc;
 
+use common_telemetry::error;
 use snafu::ResultExt;
 use tokio_postgres::types::ToSql;
 use tokio_postgres::{Client, NoTls};
@@ -97,7 +98,11 @@ impl PgStore {
         let (client, conn) = tokio_postgres::connect(url, NoTls)
             .await
             .context(ConnectPostgresSnafu)?;
-        tokio::spawn(async move { conn.await.context(ConnectPostgresSnafu) });
+        tokio::spawn(async move {
+            if let Err(e) = conn.await {
+                error!(e; "connection error");
+            }
+        });
         Self::with_pg_client(client).await
     }
 

diff --git a/src/meta-srv/src/bootstrap.rs b/src/meta-srv/src/bootstrap.rs
@@ -26,6 +26,8 @@ use common_meta::kv_backend::memory::MemoryKvBackend;
 #[cfg(feature = "pg_kvbackend")]
 use common_meta::kv_backend::postgres::PgStore;
 use common_meta::kv_backend::{KvBackendRef, ResettableKvBackendRef};
+#[cfg(feature = "pg_kvbackend")]
+use common_telemetry::error;
 use common_telemetry::info;
 use etcd_client::Client;
 use futures::future;
@@ -281,10 +283,9 @@ async fn create_postgres_client(opts: &MetasrvOptions) -> Result<tokio_postgres:
         .context(error::ConnectPostgresSnafu)?;
 
     tokio::spawn(async move {
-        connection
-            .await
-            .context(error::PostgresExecutionSnafu)
-            .unwrap()
+        if let Err(e) = connection.await {
+            error!(e; "connection error");
+        }
     });
     Ok(client)
 }
diff --git a/src/meta-srv/src/election/postgres.rs b/src/meta-srv/src/election/postgres.rs
@@ -230,6 +230,7 @@ impl PgElection {
         if res.is_empty() {
             Ok(None)
         } else {
+            // Safety: Checked if res is empty above.
             let current_time_str = res[0].get(1);
             let current_time = match Timestamp::from_str(current_time_str, None) {
                 Ok(ts) => ts,
@@ -238,7 +239,7 @@ impl PgElection {
                 }
                 .fail()?,
             };
-
+            // Safety: Checked if res is empty above.
             let value_and_expire_time = res[0].get(0);
             let (value, expire_time) = parse_value_and_expire_time(value_and_expire_time)?;