-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LoadBase Selector cannot follow the region distribution rules #2259
Merged
MichaelScofield
merged 2 commits into
GreptimeTeam:migrate-region-server
from
WenyXu:fix/load-base-selector
Sep 3, 2023
Merged
fix: LoadBase Selector cannot follow the region distribution rules #2259
MichaelScofield
merged 2 commits into
GreptimeTeam:migrate-region-server
from
WenyXu:fix/load-base-selector
Sep 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
fix/load-base-selector
branch
from
August 25, 2023 09:34
1909cc3
to
c5d5b3b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## migrate-region-server #2259 +/- ##
========================================================
Coverage ? 78.83%
========================================================
Files ? 716
Lines ? 116191
Branches ? 0
========================================================
Hits ? 91597
Misses ? 24594
Partials ? 0 |
MichaelScofield
approved these changes
Aug 30, 2023
fengjiachun
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fengys1996
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WenyXu
force-pushed
the
fix/load-base-selector
branch
from
September 2, 2023 09:47
6df9a96
to
89d13c8
Compare
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
…2259) * fix: LoadBase Selector cannot follow the region distribution rules * chore: apply suggestions from CR
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
…2259) * fix: LoadBase Selector cannot follow the region distribution rules * chore: apply suggestions from CR
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
…2259) * fix: LoadBase Selector cannot follow the region distribution rules * chore: apply suggestions from CR
WenyXu
added a commit
to WenyXu/greptimedb
that referenced
this pull request
Sep 13, 2023
…reptimeTeam#2259) * fix: LoadBase Selector cannot follow the region distribution rules * chore: apply suggestions from CR
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…reptimeTeam#2259) * fix: LoadBase Selector cannot follow the region distribution rules * chore: apply suggestions from CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
fix LoadBase Selector cannot follow the region distribution rules
Checklist
Refer to a related PR or issue link (optional)