Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LoadBase Selector cannot follow the region distribution rules #2259

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 25, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix LoadBase Selector cannot follow the region distribution rules

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu
Copy link
Member Author

WenyXu commented Aug 30, 2023

@MichaelScofield @fengjiachun PTAL

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (migrate-region-server@ef4670f). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             migrate-region-server    #2259   +/-   ##
========================================================
  Coverage                         ?   78.83%           
========================================================
  Files                            ?      716           
  Lines                            ?   116191           
  Branches                         ?        0           
========================================================
  Hits                             ?    91597           
  Misses                           ?    24594           
  Partials                         ?        0           

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun changed the base branch from develop to migrate-region-server September 1, 2023 06:48
@WenyXu WenyXu force-pushed the fix/load-base-selector branch from 6df9a96 to 89d13c8 Compare September 2, 2023 09:47
@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 3, 2023
Merged via the queue into GreptimeTeam:migrate-region-server with commit a5415a4 Sep 3, 2023
waynexia pushed a commit that referenced this pull request Sep 12, 2023
…2259)

* fix: LoadBase Selector cannot follow the region distribution rules

* chore: apply suggestions from CR
waynexia pushed a commit that referenced this pull request Sep 12, 2023
…2259)

* fix: LoadBase Selector cannot follow the region distribution rules

* chore: apply suggestions from CR
waynexia pushed a commit that referenced this pull request Sep 12, 2023
…2259)

* fix: LoadBase Selector cannot follow the region distribution rules

* chore: apply suggestions from CR
WenyXu added a commit to WenyXu/greptimedb that referenced this pull request Sep 13, 2023
…reptimeTeam#2259)

* fix: LoadBase Selector cannot follow the region distribution rules

* chore: apply suggestions from CR
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…reptimeTeam#2259)

* fix: LoadBase Selector cannot follow the region distribution rules

* chore: apply suggestions from CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants