fix: check version before alter region #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
approved these changes
Sep 18, 2023
killme2008
reviewed
Sep 18, 2023
killme2008
reviewed
Sep 18, 2023
WenyXu
force-pushed
the
fix/alter-region
branch
from
627c34f to
80e59fd
Compare
WenyXu
force-pushed
the
fix/alter-region
branch
from
80e59fd to
e226681
Compare
killme2008
reviewed
Sep 18, 2023
Co-authored-by: dennis zhuang <[email protected]>
evenyag
reviewed
Sep 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2433 +/- ##
===========================================
- Coverage 77.44% 77.38% -0.06%
===========================================
Files 726 726
Lines 114219 114227 +8
===========================================
- Hits 88461 88399 -62
- Misses 25758 25828 +70 |
evenyag
approved these changes
Sep 18, 2023
fengjiachun
approved these changes
Sep 18, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: check version before alter region * chore: apply suggestions from CR * Update src/mito2/src/worker/handle_alter.rs Co-authored-by: dennis zhuang <[email protected]> --------- Co-authored-by: dennis zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
check version before alter region
Checklist
Refer to a related PR or issue link (optional)