Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure data_home directory created #2588

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

killme2008
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fixed #2587

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2587

@killme2008 killme2008 marked this pull request as ready for review October 12, 2023 07:20
@killme2008 killme2008 requested review from WenyXu, zhongzc, fengjiachun and waynexia and removed request for WenyXu October 12, 2023 07:21
@waynexia waynexia enabled auto-merge October 12, 2023 07:29
@waynexia waynexia added this pull request to the merge queue Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2588 (b394c6f) into develop (62bcb45) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2588      +/-   ##
===========================================
- Coverage    85.36%   84.99%   -0.37%     
===========================================
  Files          737      737              
  Lines       118020   118023       +3     
===========================================
- Hits        100742   100311     -431     
- Misses       17278    17712     +434     

Merged via the queue into GreptimeTeam:develop with commit 65a659d Oct 12, 2023
18 of 19 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
fix: ensure data_home directory created before creating metadata store, GreptimeTeam#2587
@killme2008 killme2008 deleted the feature/fix-data-home branch January 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone doesn't create directory while specify data_home by env
3 participants