Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add information_schema.key_column_usage #3057

Merged
merged 6 commits into from
Dec 31, 2023

Conversation

dimbtp
Copy link
Contributor

@dimbtp dimbtp commented Dec 30, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • add information_schema.key_column_usage table

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2931

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Dec 30, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 168 lines in your changes are missing coverage. Please review.

Comparison is base (6070e88) 85.45% compared to head (ed504bc) 84.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   85.45%   84.81%   -0.65%     
==========================================
  Files         799      800       +1     
  Lines      129155   129395     +240     
==========================================
- Hits       110373   109740     -633     
- Misses      18782    19655     +873     

@niebayes niebayes requested a review from killme2008 December 31, 2023 01:35
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you.

A few suggestions are attached, please take a look. And i think it's better to add some sql to test this table to tests/cases/standalone/common/system/information_schema.sql, just like

We can ensure the virutal table results are correct.

@killme2008
Copy link
Contributor

BTW. After #3054 merged, some conflicts have to be resolved right now.

@github-actions github-actions bot added Size: M and removed Size: L labels Dec 31, 2023
@github-actions github-actions bot added Size: L and removed Size: M labels Dec 31, 2023
@dimbtp dimbtp requested a review from killme2008 December 31, 2023 06:30
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

@sunng87 sunng87 added this pull request to the merge queue Dec 31, 2023
Merged via the queue into GreptimeTeam:main with commit f735f73 Dec 31, 2023
15 checks passed
@dimbtp dimbtp deleted the feature/key-column-usage branch December 31, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants