-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add information_schema.key_column_usage #3057
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3057 +/- ##
==========================================
- Coverage 85.45% 84.81% -0.65%
==========================================
Files 799 800 +1
Lines 129155 129395 +240
==========================================
- Hits 110373 109740 -633
- Misses 18782 19655 +873 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thank you.
A few suggestions are attached, please take a look. And i think it's better to add some sql to test this table to tests/cases/standalone/common/system/information_schema.sql
, just like
select * from CHARACTER_SETS; |
We can ensure the virutal table results are correct.
BTW. After #3054 merged, some conflicts have to be resolved right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much!
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
information_schema.key_column_usage
tableChecklist
Refer to a related PR or issue link (optional)
#2931