Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abort region migration if leader region peer is unexpected #3086

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Abort region migration if leader region peer is unexpected

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu added the docs-not-required This change does not impact docs. label Jan 3, 2024
@WenyXu WenyXu self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (611a8aa) 85.70% compared to head (83ef833) 85.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
- Coverage   85.70%   85.17%   -0.53%     
==========================================
  Files         805      805              
  Lines      130814   130864      +50     
==========================================
- Hits       112117   111467     -650     
- Misses      18697    19397     +700     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu mentioned this pull request Jan 3, 2024
39 tasks
@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 3, 2024
Merged via the queue into GreptimeTeam:main with commit 21694c2 Jan 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants