Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix non-physical error msg #3087

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix non-physical error msg

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu added the docs-not-required This change does not impact docs. label Jan 3, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun enabled auto-merge January 3, 2024 08:10
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (611a8aa) 85.70% compared to head (5487a3d) 85.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   85.70%   85.17%   -0.54%     
==========================================
  Files         805      805              
  Lines      130814   130814              
==========================================
- Hits       112117   111415     -702     
- Misses      18697    19399     +702     

@WenyXu WenyXu requested review from killme2008 and zhongzc January 3, 2024 08:27
@fengjiachun fengjiachun added this pull request to the merge queue Jan 3, 2024
Merged via the queue into GreptimeTeam:main with commit b2b7523 Jan 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants