-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pushdown filters for some information_schema tables #3091
Merged
killme2008
merged 14 commits into
GreptimeTeam:main
from
killme2008:feature/information-schema-pushdown-filter
Jan 5, 2024
Merged
feat: pushdown filters for some information_schema tables #3091
killme2008
merged 14 commits into
GreptimeTeam:main
from
killme2008:feature/information-schema-pushdown-filter
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
added
docs-not-required
This change does not impact docs.
and removed
docs-required
This change requires docs update.
labels
Jan 3, 2024
killme2008
requested review from
zhongzc,
MichaelScofield,
waynexia and
v0y4g3r
January 4, 2024 02:32
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3091 +/- ##
==========================================
- Coverage 85.61% 85.19% -0.43%
==========================================
Files 804 807 +3
Lines 131031 132101 +1070
==========================================
+ Hits 112180 112541 +361
- Misses 18851 19560 +709 |
zhongzc
reviewed
Jan 4, 2024
zhongzc
reviewed
Jan 4, 2024
killme2008
force-pushed
the
feature/information-schema-pushdown-filter
branch
from
January 4, 2024 10:17
6c49e04
to
b8f5a73
Compare
@zhongzc PTAL |
zhongzc
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MichaelScofield
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Some tables in
information_schema
will be large in the production when there are many created tables, such ascolumns
andtables
etc.This PR supports pushing down query filters for some information_schema tables, it would reduce the memory consumption while constructing the result stream and speed up the query.
Currently it supports following filters:
Eq
NotEq
InList
expr AND expr
expr OR expr
NOT expr
expr LIKE pattern
We can support more types in the future. Looks like datafusion doesn't push down
like
expression currently. @waynexiaChecklist
Refer to a related PR or issue link (optional)
#2931