fix(util): join_path function should not trim leading /
#3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hudson C. Dalpra <[email protected]>
github-actions
bot
added
docs-not-required
|
@tisonkun you are welcome to review it and let me know about any necessary changes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3280 +/- ##
==========================================
- Coverage 85.69% 85.07% -0.63%
==========================================
Files 859 871 +12
Lines 140796 141519 +723
==========================================
- Hits 120662 120393 -269
- Misses 20134 21126 +992 |
tisonkun
reviewed
Feb 4, 2024
v0y4g3r
reviewed
Feb 5, 2024
tisonkun
approved these changes
Feb 6, 2024
evenyag
reviewed
Feb 7, 2024
evenyag
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed, and what's your intention?
Replaced
opendal::raw::normalize_pathwith own implementation ofnormalize_pathin order to fix expected behaviour of not trimming leading'/'.Also fixed some typing errors (I believe) when I was reading the Makefile.
Checklist
Refer to a related PR or issue link (optional)
Closes #3212