-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): watch file user provider #3566
feat(auth): watch file user provider #3566
Conversation
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3566 +/- ##
==========================================
- Coverage 85.21% 84.85% -0.37%
==========================================
Files 924 925 +1
Lines 153524 153676 +152
==========================================
- Hits 130831 130401 -430
- Misses 22693 23275 +582 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Looks cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the comments. Let's go 🚀
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
All addressed. I may wait a bit for any feedback on #3566 (comment); otherwise, I'll merge this one tomorrow. |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
This reverts commit d7a0be1.
7703b68
to
b7f5336
Compare
Signed-off-by: tison <[email protected]>
872b79d
to
6a5d833
Compare
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
886c114
to
cc48871
Compare
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
b734068
to
408f8df
Compare
I'll merge this as is now. If you have other ideas on #3566 (comment), please drop a comment. We still have the chance to make changes before 0.8 or even 1.0 release. |
@tisonkun Looks like we need to update the doc https://docs.greptime.com/user-guide/clients/authentication#authentication |
Thanks for pointing out the doc source. I'll update for this and the admin |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This closes #1862.
Implement
greptime standalone start --user-provider=watch_file_user_provider:./users.toml
that would watch on the file for updates.This is what @thinkORo wants in the original issue, but in a way more suitable for our model.
Checklist