-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update physical table schema on alter logical tables #3585
feat: update physical table schema on alter logical tables #3585
Conversation
866edde
to
1616175
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
==========================================
- Coverage 85.19% 84.81% -0.39%
==========================================
Files 924 926 +2
Lines 153492 153645 +153
==========================================
- Hits 130773 130318 -455
- Misses 22719 23327 +608 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/common/meta/src/ddl/alter_logical_tables/update_metadata.rs
Outdated
Show resolved
Hide resolved
@evenyag PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Checklist